imx6: drop duplicated bss memset and board_init_r() call
PATCH 1/1 imx6: drop duplicated bss memset and board_init_r() call
bss section is cleared in crt0.S. board_init_r() is also entered from crt0 code.
Signed-off-by Anatolij Gustschin <[email protected]>
Cc Christian Gmeiner <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Tim Harvey <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Lukasz Majewski <[email protected]>
Cc Fabio Estevam <[email protected]>
--- board/bachmann/ot1200/ot1200_spl.c | 6 ------ board/compulab/cm_fx6/spl.c | 3 --- board/engicam/common/spl.c | 6 ------ board/gateworks/gw_ventana/gw_ventana_spl.c | 3 --- board/kosagi/novena/novena_spl.c | 6 ------ board/liebherr/mccmon6/spl.c | 6 ------ board/udoo/udoo_spl.c | 6 ------ board/wandboard/spl.c | 6 ------ 8 files changed, 42 deletions(-)
board/bachmann/ot1200/ot1200_spl.c +0 -6
@@ -151,10 +151,4 @@ void board_init_f(ulong dummy)/* configure MMDC for SDRAM width/size and per-model calibration */ ot1200_spl_dram_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }
board/compulab/cm_fx6/spl.c +0 -3
@@ -336,9 +336,6 @@ void board_init_f(ulong dummy)puts ("!!!ERROR!!! DRAM detection failed!!!\n" );hang (); } - -memset (__bss_start,0 , __bss_end - __bss_start); -board_init_r (NULL ,0 ); }void board_boot_order (u32 *spl_boot_list)
board/engicam/common/spl.c +0 -6
@@ -384,10 +384,4 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }
board/gateworks/gw_ventana/gw_ventana_spl.c +0 -3
@@ -637,9 +637,6 @@ void board_init_f(ulong dummy)spl_dram_init (8 << ventana_info.sdram_width,16 << ventana_info.sdram_size, board_model); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); }void board_boot_order (u32 *spl_boot_list)
board/kosagi/novena/novena_spl.c +0 -6
@@ -607,10 +607,4 @@ void board_init_f(ulong dummy)udelay (100 );mmdc_do_write_level_calibration (&novena_ddr_info);mmdc_do_dqs_calibration (&novena_ddr_info); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }
board/liebherr/mccmon6/spl.c +0 -6
@@ -307,11 +307,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif
board/udoo/udoo_spl.c +0 -6
@@ -263,11 +263,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif
board/wandboard/spl.c +0 -6
@@ -311,11 +311,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif
Signature · 1 line
2.7.4
PATCH 1/1 imx6: drop duplicated bss memset and board_init_r() call
Hi Anatolij,
Quoted 2 lines
bss section is cleared in
crt0.S.board_init_r()is also entered from crt0 code.
Reviewed-by Lukasz Majewski <[email protected]>
Quoted 142 lines
Signed-off-by Anatolij Gustschin <[email protected]>Cc Christian Gmeiner <[email protected]>Cc Nikita Kiryanov <[email protected]>Cc Jagan Teki <[email protected]>Cc Tim Harvey <[email protected]>Cc Marek Vasut <[email protected]>Cc Lukasz Majewski <[email protected]>Cc Fabio Estevam <[email protected]>--- board/bachmann/ot1200/ot1200_spl.c | 6 ------ board/compulab/cm_fx6/spl.c | 3 --- board/engicam/common/spl.c | 6 ------ board/gateworks/gw_ventana/gw_ventana_spl.c | 3 --- board/kosagi/novena/novena_spl.c | 6 ------ board/liebherr/mccmon6/spl.c | 6 ------ board/udoo/udoo_spl.c | 6 ------ board/wandboard/spl.c | 6 ------ 8 files changed, 42 deletions(-)board/bachmann/ot1200/ot1200_spl.c +0
-6@@ -151,10 +151,4 @@ void board_init_f(ulong dummy)/* configure MMDC for SDRAM width/size and per-model calibration */ ot1200_spl_dram_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }board/compulab/cm_fx6/spl.c +0
-3@@ -336,9 +336,6 @@ void board_init_f(ulong dummy)puts ("!!!ERROR!!! DRAM detection failed!!!\n" );hang (); } - -memset (__bss_start,0 , __bss_end - __bss_start); -board_init_r (NULL ,0 ); }void board_boot_order (u32 *spl_boot_list)board/engicam/common/spl.c +0
-6@@ -384,10 +384,4 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }board/gateworks/gw_ventana/gw_ventana_spl.c +0
-3@@ -637,9 +637,6 @@ void board_init_f(ulong dummy)spl_dram_init (8 << ventana_info.sdram_width,16 << ventana_info.sdram_size, board_model); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); }void board_boot_order (u32 *spl_boot_list)board/kosagi/novena/novena_spl.c +0
-6@@ -607,10 +607,4 @@ void board_init_f(ulong dummy)udelay (100 );mmdc_do_write_level_calibration (&novena_ddr_info);mmdc_do_dqs_calibration (&novena_ddr_info); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }board/liebherr/mccmon6/spl.c +0
-6@@ -307,11 +307,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif board/udoo/udoo_spl.c +0
-6@@ -263,11 +263,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif board/wandboard/spl.c +0
-6@@ -311,11 +311,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif
Signature · 9 lines
Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
PATCH 1/1 imx6: drop duplicated bss memset and board_init_r() call
In reply to Anatolij Gustschin2017-08-28 20:58 GMT+02:00 Anatolij Gustschin <[email protected]>:
Quoted 4 lines
bss section is cleared in
crt0.S.board_init_r()is also entered from crt0 code.Signed-off-by Anatolij Gustschin <[email protected]>
Reviewed-by Christian Gmeiner <[email protected]>
Quoted 140 lines
Cc Christian Gmeiner <[email protected]>Cc Nikita Kiryanov <[email protected]>Cc Jagan Teki <[email protected]>Cc Tim Harvey <[email protected]>Cc Marek Vasut <[email protected]>Cc Lukasz Majewski <[email protected]>Cc Fabio Estevam <[email protected]>--- board/bachmann/ot1200/ot1200_spl.c | 6 ------ board/compulab/cm_fx6/spl.c | 3 --- board/engicam/common/spl.c | 6 ------ board/gateworks/gw_ventana/gw_ventana_spl.c | 3 --- board/kosagi/novena/novena_spl.c | 6 ------ board/liebherr/mccmon6/spl.c | 6 ------ board/udoo/udoo_spl.c | 6 ------ board/wandboard/spl.c | 6 ------ 8 files changed, 42 deletions(-)board/bachmann/ot1200/ot1200_spl.c +0
-6@@ -151,10 +151,4 @@ void board_init_f(ulong dummy)/* configure MMDC for SDRAM width/size and per-model calibration */ ot1200_spl_dram_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }board/compulab/cm_fx6/spl.c +0
-3@@ -336,9 +336,6 @@ void board_init_f(ulong dummy)puts ("!!!ERROR!!! DRAM detection failed!!!\n" );hang (); } - -memset (__bss_start,0 , __bss_end - __bss_start); -board_init_r (NULL ,0 ); }void board_boot_order (u32 *spl_boot_list)board/engicam/common/spl.c +0
-6@@ -384,10 +384,4 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }board/gateworks/gw_ventana/gw_ventana_spl.c +0
-3@@ -637,9 +637,6 @@ void board_init_f(ulong dummy)spl_dram_init (8 << ventana_info.sdram_width,16 << ventana_info.sdram_size, board_model); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); }void board_boot_order (u32 *spl_boot_list)board/kosagi/novena/novena_spl.c +0
-6@@ -607,10 +607,4 @@ void board_init_f(ulong dummy)udelay (100 );mmdc_do_write_level_calibration (&novena_ddr_info);mmdc_do_dqs_calibration (&novena_ddr_info); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }board/liebherr/mccmon6/spl.c +0
-6@@ -307,11 +307,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif board/udoo/udoo_spl.c +0
-6@@ -263,11 +263,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ - board_init_r(NULL, 0); }#endif board/wandboard/spl.c +0
-7@@ -311,11 +311,5 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init(); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - -/* load/boot image from boot device */ -board_init_r (NULL ,0 ); }#endif --
Quoted 2 lines
2.7.4
greets
--
Christian Gmeiner, MSc
PATCH 1/1 imx6: drop duplicated bss memset and board_init_r() call
In reply to Anatolij GustschinQuoted 4 lines · Anatolij Gustschin
bss section is cleared in
crt0.S.board_init_r()is also entered from crt0 code.Signed-off-by Anatolij Gustschin <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
PATCH 1/1 imx6: drop duplicated bss memset and board_init_r() call
In reply to Anatolij GustschinQuoted 11 lines · Anatolij Gustschin
bss section is cleared in
crt0.S.board_init_r()is also entered from crt0 code.Signed-off-by Anatolij Gustschin <[email protected]>Cc Christian Gmeiner <[email protected]>Cc Nikita Kiryanov <[email protected]>Cc Jagan Teki <[email protected]>Cc Tim Harvey <[email protected]>Cc Marek Vasut <[email protected]>Cc Lukasz Majewski <[email protected]>Cc Fabio Estevam <[email protected]>
Quoted 1 line
---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================