Skip to contentSkip to conversation

staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

PATCH Superseded Jonathan Whitaker 2 participants 5 messages Aug 30, 2017 – Aug 31, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

It is prefered to use '"%s...", __func__ instead of function names for logging. This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' style. These warnings were reported by checkpatch.pl.

Changes in v2:
- Wrapped the changelog text to 72 columns.
- Fixed the commit subject to be more clear.

---
 drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +2 -2
index 9b28ee1..c0e91c3 100644
@@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	unsigned char byte;
 	int ret;
 
-	DPRINTK(5, "ks7010_sdio_probe()\n");
+	DPRINTK(5, "%s()\n", __func__);
 
 	priv = NULL;
 	netdev = NULL;
@@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
 
-	DPRINTK(1, "ks7010_sdio_remove()\n");
+	DPRINTK(1, "%s()\n", __func__);
 
 	card = sdio_get_drvdata(func);
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 11 lines · Jonathan Whitaker

It is prefered to use '"%s...", __func__ instead of function names for logging. This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' style. These warnings were reported by checkpatch.pl.

Changes in v2:
- Wrapped the changelog text to 72 columns.
- Fixed the commit subject to be more clear.
---

Put the Changelog under the --- cut off line.

drivers/staging/ks7010/ks7010_sdio.c static int ks7010_sdio_probe(struct sdio_func *func, · line 837

Quoted 13 lines
 drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +1 -1
index 9b28ee1..c0e91c3 100644
@@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	unsigned char byte;
 	int ret;
 
-	DPRINTK(5, "ks7010_sdio_probe()\n");
+	DPRINTK(5, "%s()\n", __func__);

Just delete both the printks. You can get the same information with ftrace.

regards,
dan carpenter

#2 lore raw

PATCH v3 1/1 staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

Removed printk statements for debugging. The same information can be acquired via ftrace, so these print statements are uneccessary.

---
Changes in v2:
- Wrapped the changelog text to 72 columns.
- Fixed the commit subject to be more clear.

Changes in v3:
- Removed the printk statements altogether. This information is available via ftrace.
- Updated commit message.

---
 drivers/staging/ks7010/ks7010_sdio.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +0 -4
index 9b28ee1..8cfdff1 100644
@@ -834,8 +834,6 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	unsigned char byte;
 	int ret;
 
-	DPRINTK(5, "ks7010_sdio_probe()\n");
-
 	priv = NULL;
 	netdev = NULL;
 
@@ -1008,8 +1006,6 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
 
-	DPRINTK(1, "ks7010_sdio_remove()\n");
-
 	card = sdio_get_drvdata(func);
 
 	if (!card)
Signature · 1 line
2.7.4
#4 lore raw

Thank you for all of the feedback!

Quoted 5 lines · Dan Carpenter

Thanks!

regards,
dan carpenter