usbip: vhci-hcd: make vhci_hc_driver const

PATCH In review Bhumika Goyal 2 participants 2 messages Aug 30, 2017

Subsystems (2)

USB USB over IP driver

lore

Share & tools

lore

Bhumika Goyal

author

2017-08-30 12:52 UTC #0 lore raw

PATCH 1/1 usbip: vhci-hcd: make vhci_hc_driver const

Make this const as it is not modified anywhere.

Signed-off-by Bhumika Goyal <[email protected]>

---
 drivers/usb/usbip/vhci_hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/usbip/vhci_hcd.c +1 -1

index c747623..11b9a22 100644
@@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
 	return 0;
 }
 
-static struct hc_driver vhci_hc_driver = {
+static const struct hc_driver vhci_hc_driver = {
 	.description	= driver_name,
 	.product_desc	= driver_desc,
 	.hcd_priv_size	= sizeof(struct vhci_hcd),

Signature · 1 line

1.9.1

Shuah Khan

maintainer Acked-by on v1 1/1

2017-08-30 17:27 UTC #1 lore raw

Quoted 13 lines · Bhumika Goyal

Make this const as it is not modified anywhere.
Signed-off-by Bhumika Goyal <[email protected]>
---
 drivers/usb/usbip/vhci_hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/usbip/vhci_hcd.c +0 -0
index c747623..11b9a22 100644

drivers/usb/usbip/vhci_hcd.c static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev, · line 1280

Quoted 8 lines

drivers/usb/usbip/vhci_hcd.c +1 -1

@@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
 	return 0;
 }
 
-static struct hc_driver vhci_hc_driver = {
+static const struct hc_driver vhci_hc_driver = {
 	.description	= driver_name,
 	.product_desc	= driver_desc,
 	.hcd_priv_size	= sizeof(struct vhci_hcd),

Looks good to me.

Acked-by Shuah Khan <[email protected]>

thanks,
-- Shuah