Skip to contentSkip to conversation

Patch "btrfs: remove duplicate const specifier" has been added to the 4.4-stable tree

PATCH [email protected] 2 participants 3 messages Aug 30, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

btrfs: remove duplicate const specifier

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
btrfs-remove-duplicate-const-specifier.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From fb75d857a31d600cc0c37b8c7d914014f7fa3f9a Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Tue, 19 Jan 2016 00:05:28 +0000
Subject: btrfs: remove duplicate const specifier

From: Colin Ian King <[email protected]>

commit fb75d857a31d600cc0c37b8c7d914014f7fa3f9a upstream.

duplicate const is redundant so remove it

---
 fs/btrfs/volumes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/volumes.c +1 -1
@@ -108,7 +108,7 @@ const struct btrfs_raid_attr btrfs_raid_
 	},
 };
 
-const u64 const btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
+const u64 btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
 	[BTRFS_RAID_RAID10] = BTRFS_BLOCK_GROUP_RAID10,
 	[BTRFS_RAID_RAID1]  = BTRFS_BLOCK_GROUP_RAID1,
 	[BTRFS_RAID_DUP]    = BTRFS_BLOCK_GROUP_DUP,

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/btrfs-remove-duplicate-const-specifier.patch

#1 lore raw
Quoted 8 lines · On Wed, Aug 30, 2017 at 05:29:36PM +0200, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

btrfs: remove duplicate const specifier

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
btrfs-remove-duplicate-const-specifier.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

This patch IMO does not belong to stable, it's just a cleanup and does not fix anything that's worth the time of anybody involved in stable trees.

Quoted 36 lines

From fb75d857a31d600cc0c37b8c7d914014f7fa3f9a Mon Sep 17 00:00:00 2001
From: Colin Ian King <[email protected]>
Date: Tue, 19 Jan 2016 00:05:28 +0000
Subject: btrfs: remove duplicate const specifier

From: Colin Ian King <[email protected]>

commit fb75d857a31d600cc0c37b8c7d914014f7fa3f9a upstream.

duplicate const is redundant so remove it

---
 fs/btrfs/volumes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/volumes.c +1 -1
@@ -108,7 +108,7 @@ const struct btrfs_raid_attr btrfs_raid_
 	},
 };
 
-const u64 const btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
+const u64 btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
 	[BTRFS_RAID_RAID10] = BTRFS_BLOCK_GROUP_RAID10,
 	[BTRFS_RAID_RAID1]  = BTRFS_BLOCK_GROUP_RAID1,
 	[BTRFS_RAID_DUP]    = BTRFS_BLOCK_GROUP_DUP,

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/btrfs-remove-duplicate-const-specifier.patch

author maintainer
#2 lore raw
Quoted 13 lines · David Sterba
Quoted 12 lines · On Wed, Aug 30, 2017 at 05:29:36PM +0200, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

btrfs: remove duplicate const specifier

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
btrfs-remove-duplicate-const-specifier.patch
and it can be found in the queue-4.4 subdirectory.

Quoted 5 lines
Quoted 2 lines

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

This patch IMO does not belong to stable, it's just a cleanup and does not fix anything that's worth the time of anybody involved in stable trees.

On the contrary, it fixes a build warning in the tree, and having lots of warnings hides real problems. The tree used to build "clean" with gcc6, but now that my build systems are running gcc7, stuff like this needs to get cleaned up again.

So this is a needed fix.

thanks,

greg k-h