Skip to contentSkip to conversation

Patch "i2c: jz4780: drop superfluous init" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 30, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

i2c: jz4780: drop superfluous init

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     i2c-jz4780-drop-superfluous-init.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 27bfeb5a0619554d9734fb39e14f0e80fa7c342c Mon Sep 17 00:00:00 2001

From: Wolfram Sang <[email protected]>
Date: Sun, 5 Jun 2016 11:41:42 +0200
Subject: i2c: jz4780: drop superfluous init

From: Wolfram Sang <[email protected]>

commit 27bfeb5a0619554d9734fb39e14f0e80fa7c342c upstream.

David reported that the length for memset was incorrect (element sizes were not taken into account). Then I saw that we are clearing kzalloced memory, so we can simply drop this code.

---
 drivers/i2c/busses/i2c-jz4780.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/i2c/busses/i2c-jz4780.c +0 -4
@@ -786,10 +786,6 @@ static int jz4780_i2c_probe(struct platf
 
 	jz4780_i2c_writew(i2c, JZ4780_I2C_INTM, 0x0);
 
-	i2c->cmd = 0;
-	memset(i2c->cmd_buf, 0, BUFSIZE);
-	memset(i2c->data_buf, 0, BUFSIZE);
-
 	i2c->irq = platform_get_irq(pdev, 0);
 	ret = devm_request_irq(&pdev->dev, i2c->irq, jz4780_i2c_irq, 0,
 			       dev_name(&pdev->dev), i2c);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/i2c-jz4780-drop-superfluous-init.patch