Skip to contentSkip to conversation

Patch "i2c: ismt: Return EMSGSIZE for block reads with bogus length" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Sep 4, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

i2c: ismt: Return EMSGSIZE for block reads with bogus length

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
i2c-ismt-return-emsgsize-for-block-reads-with-bogus-length.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ba201c4f5ebe13d7819081756378777d8153f23e Mon Sep 17 00:00:00 2001

From: Stephen Douthit <[email protected]>
Date: Mon, 7 Aug 2017 17:11:00 -0400
Subject: i2c: ismt: Return EMSGSIZE for block reads with bogus length

From: Stephen Douthit <[email protected]>

commit ba201c4f5ebe13d7819081756378777d8153f23e upstream.

Compare the number of bytes actually seen on the wire to the byte count field returned by the slave device.

Previously we just overwrote the byte count returned by the slave with the real byte count and let the caller figure out if the message was sane.

---
 drivers/i2c/busses/i2c-ismt.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-ismt.c +3 -1
@@ -341,8 +341,10 @@ static int ismt_process_desc(const struc
 			break;
 		case I2C_SMBUS_BLOCK_DATA:
 		case I2C_SMBUS_I2C_BLOCK_DATA:
+			if (desc->rxbytes != dma_buffer[0] + 1)
+				return -EMSGSIZE;
+
 			memcpy(data->block, dma_buffer, desc->rxbytes);
-			data->block[0] = desc->rxbytes - 1;
 			break;
 		}
 		return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/i2c-ismt-don-t-duplicate-the-receive-length-for-block-reads.patch queue-4.12/i2c-ismt-return-emsgsize-for-block-reads-with-bogus-length.patch