nvdimm: move the check on nd_reserved2 to the endpoint
Subsystems (2)
PATCH 1/1 nvdimm: move the check on nd_reserved2 to the endpoint
This patch delays the check of nd_reserved2 to the actual endpoint (acpi_nfit_ctl) that uses it, as a prevention of a potential double-fetch bug.
Detailed discussion can be found at
https://marc.info/?l=linux-kernel&m=150421938113092&w=2
--- drivers/acpi/nfit/core.c | 4 ++++ drivers/nvdimm/bus.c | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/acpi/nfit/core.c +4 -0
@@ -228,6 +228,10 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,if (cmd ==ND_CMD_CALL ) { call_pkg = buf; func = call_pkg->nd_command; + +for (i =0 ; i <ARRAY_SIZE (call_pkg->nd_reserved2); i++) +if (call_pkg->nd_reserved2[i]) +return -EINVAL ; }if (nvdimm) {
drivers/nvdimm/bus.c +0 -4
@@ -980,10 +980,6 @@ static int __nd_ioctl(struct nvdimm_bus *nvdimm_bus, struct nvdimm *nvdimm,dev_dbg (dev,"%s:%s, idx: %llu, in: %zu, out: %zu, len %zu\n" , __func__, dimm_name, pkg.nd_command, in_len, out_len, buf_len); - -for (i =0 ; i <ARRAY_SIZE (pkg.nd_reserved2); i++) -if (pkg.nd_reserved2[i]) -return -EINVAL ; }/* process an output envelope */
Signature · 6 lines
2.7.4 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 6 lines · Meng Xu
This patch delays the check of
nd_reserved2to the actual endpoint (acpi_nfit_ctl) that uses it, as a prevention of a potential double-fetch bug.Detailed discussion can be found at
https://marc.info/?l=linux-kernel&m=150421938113092&w=2
Thanks for doing this, I went ahead and copied this discussion into the patch and applied it.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm