Skip to contentSkip to conversation

tracing: Fix clear of RECORDED_TGID flag when disabling trace event

PATCH Applied Chunyu Hu 2 participants 2 messages Sep 5, 2017 Tracing

lore
Share & tools
lore

Chunyu Hu

author
#0 lore raw

PATCH 1/1 tracing: Fix clear of RECORDED_TGID flag when disabling trace event

When disabling one trace event, the RECORDED_TGID flag in the event file is not correctly cleared. It's clearing RECORDED_CMD flag when it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support for recording tgid of tasks")

---
 kernel/trace/trace_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_events.c +1 -1
index c93540c..8746839 100644
@@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file,
 
 			if (file->flags & EVENT_FILE_FL_RECORDED_TGID) {
 				tracing_stop_tgid_record();
-				clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags);
+				clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags);
 			}
 
 			call->class->reg(call, TRACE_REG_UNREGISTER, file);
Signature · 1 line
1.8.3.1
maintainer Applied
#1 lore raw
Quoted 6 lines · On Tue, 5 Sep 2017 13:36:46 +0800 Chunyu Hu <[email protected]> wrote:

When disabling one trace event, the RECORDED_TGID flag in the event file is not correctly cleared. It's clearing RECORDED_CMD flag when it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support for recording tgid of tasks")

Thanks! Applied.

-- Steve

Quoted 17 lines
---
 kernel/trace/trace_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_events.c +1 -1
index c93540c..8746839 100644
@@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file,
 
 			if (file->flags & EVENT_FILE_FL_RECORDED_TGID) {
 				tracing_stop_tgid_record();
-				clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags);
+				clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags);
 			}
 
 			call->class->reg(call, TRACE_REG_UNREGISTER, file);