htdocs/js/series.js: Default to cover letter view only if one is available
PATCH 1/1 htdocs/js/series.js: Default to cover letter view only if one is available
Cover letter content section is displayed by default at the Series view even if no cover letter is available, providing a poor UX.
This change makes the Cover letter content section to be displayed by default if a cover letter is available, otherwise the Patches list is to be displayed by default at the Series view and the Cover letter tab will include a "N/A" legend and an informative tooltip when hover over the mouse cursor.
[YOCTO #11887]
Signed-off-by Jose Lamego <[email protected]>
--- htdocs/js/series.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
htdocs/js/series.js +11 -2
@@ -7,6 +7,8 @@ $(document).ready(function(){ patchesInput=$( "input[name^='patches']" ) seriesForms=document.getElementById('seriesForm') testsView=document.getElementById('tests_results') + covContent=document.getElementsByClassName('content')[0] + covTab=document.getElementById('cover-letter-tab') var patches = new Array() if ($( patchesInput[0] ).value){ patches=json_decode($( patchesInput[0] ).value, true)
@@ -17,9 +19,16 @@ $(document).ready(function(){ revTab.style.border='none' revTab.style.background='transparent' revTab.style.padding='15px' - coverView.style.display='block' patchView.style.display='none' - patchList.style.display='none' + if (covContent){ + coverView.style.display='block' + patchList.style.display='none' + } + else{ + covTab.innerHTML = '<a href="#" data-toggle="tooltip" title="No cover letter is available for this series.">Cover letter N/A</a>' + coverView.style.display='none' + patchList.style.display='block' + } seriesForms.style.display='none' document.getElementById('cover-letter-tab').onclick=function(){
Signature · 1 line
2.7.4