Patch "drm/nouveau: Fix error handling in nv50_disp_atomic_commit" has been added to the 4.12-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
drm/nouveau: Fix error handling in nv50_disp_atomic_commit
to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-nouveau-fix-error-handling-in-nv50_disp_atomic_commit.patch
and it can be found in the queue-4.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
813a7e1604eaad1c2792d37d402e1b48b8d0eb3fMon Sep 17 00:00:00 2001
From: Maarten Lankhorst <[email protected]>
Date: Tue, 11 Jul 2017 16:33:03 +0200
Subject: drm/nouveau: Fix error handling in nv50_disp_atomic_commit
From: Maarten Lankhorst <[email protected]>
commit 813a7e1604eaad1c2792d37d402e1b48b8d0eb3f upstream.
Make it more clear that post commit return ret is really return 0,
and add a missing drm_atomic_helper_cleanup_planes when drm_atomic_helper_wait_for_fences fails.
--- drivers/gpu/drm/nouveau/nv50_display.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nv50_display.c +5 -2
@@ -4091,7 +4091,7 @@ nv50_disp_atomic_commit(struct drm_devicif (!nonblock) { ret =drm_atomic_helper_wait_for_fences (dev, state, true);if (ret) - goto done; + goto err_cleanup; }for_each_plane_in_state (state, plane, plane_state, i) {
@@ -4119,7 +4119,7 @@ nv50_disp_atomic_commit(struct drm_devicif (crtc->state->enable) {if (!drm->have_disp_power_ref) { drm->have_disp_power_ref = true; -return ret; +return 0 ; } active = true;break ;
@@ -4131,6 +4131,9 @@ nv50_disp_atomic_commit(struct drm_devic drm->have_disp_power_ref = false; } +err_cleanup: +if (ret) +drm_atomic_helper_cleanup_planes (dev, state); done:pm_runtime_put_autosuspend (dev->dev);return ret;
Patches currently in stable-queue which might be from [email protected] are
queue-4.12/drm-nouveau-fix-error-handling-in-nv50_disp_atomic_commit.patch