Skip to contentSkip to conversation

Patch "iio: adc: ti-ads1015: don't return invalid value from buffer setup callbacks" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Sep 7, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: adc: ti-ads1015: don't return invalid value from buffer setup callbacks

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-adc-ti-ads1015-don-t-return-invalid-value-from-buffer-setup-callbacks.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a6fe5e52d5ecfc98530034d6c9db73777cf41ede Mon Sep 17 00:00:00 2001

From: Akinobu Mita <[email protected]>
Date: Fri, 21 Jul 2017 00:24:21 +0900
Subject: iio: adc: ti-ads1015: don't return invalid value from buffer setup callbacks

From: Akinobu Mita <[email protected]>

commit a6fe5e52d5ecfc98530034d6c9db73777cf41ede upstream.

pm_runtime_get_sync() and pm_runtime_put_autosuspend() return 0 on success, 1 if the device's runtime PM status was already requested status or error code on failure. So a positive return value doesn't indicate an error condition.

However, any non-zero return values from buffer preenable and postdisable callbacks are recognized as an error and this driver reuses the return value from pm_runtime_get_sync() and pm_runtime_put_autosuspend() in these callbacks. This change fixes the false error detections.

---
 drivers/iio/adc/ti-ads1015.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti-ads1015.c +1 -1
@@ -235,7 +235,7 @@ static int ads1015_set_power_state(struc
 		ret = pm_runtime_put_autosuspend(dev);
 	}
 
-	return ret;
+	return ret < 0 ? ret : 0;
 }
 
 static

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/iio-adc-ti-ads1015-enable-conversion-when-config_pm-is-not-set.patch queue-4.12/iio-adc-ti-ads1015-add-adequate-wait-time-to-get-correct-conversion.patch queue-4.12/iio-adc-ti-ads1015-don-t-return-invalid-value-from-buffer-setup-callbacks.patch queue-4.12/iio-adc-ti-ads1015-fix-incorrect-data-rate-setting-update.patch queue-4.12/iio-adc-ti-ads1015-fix-scale-information-for-ads1115.patch queue-4.12/iio-adc-ti-ads1015-avoid-getting-stale-result-after-runtime-resume.patch