Skip to contentSkip to conversation

Patch "iio: adc: ti-ads1015: enable conversion when CONFIG_PM is not set" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Sep 7, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: adc: ti-ads1015: enable conversion when CONFIG_PM is not set

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-adc-ti-ads1015-enable-conversion-when-config_pm-is-not-set.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From e8245c68350104b6022b6783719e843d69ea7c43 Mon Sep 17 00:00:00 2001

From: Akinobu Mita <[email protected]>
Date: Fri, 21 Jul 2017 00:24:19 +0900
Subject: iio: adc: ti-ads1015: enable conversion when CONFIG_PM is not set

From: Akinobu Mita <[email protected]>

commit e8245c68350104b6022b6783719e843d69ea7c43 upstream.

The ADS1015 device have two operating modes, continuous conversion mode and single-shot mode. This driver assumes that the continuous conversion mode is selected by runtime resume callback when the ADC result is requested.

If CONFIG_PM is disabled, the device is always in the default single-shot mode and no one begins a single conversion. So the conversion register doesn't contain valid ADC result. Fix it by changing the continuous mode in probe function.

---
 drivers/iio/adc/ti-ads1015.c |    7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/adc/ti-ads1015.c +7 -0
@@ -623,6 +623,13 @@ static int ads1015_probe(struct i2c_clie
 		dev_err(&client->dev, "iio triggered buffer setup failed\n");
 		return ret;
 	}
+
+	ret = regmap_update_bits(data->regmap, ADS1015_CFG_REG,
+				ADS1015_CFG_MOD_MASK,
+				ADS1015_CONTINUOUS << ADS1015_CFG_MOD_SHIFT);
+	if (ret)
+		return ret;
+
 	ret = pm_runtime_set_active(&client->dev);
 	if (ret)
 		goto err_buffer_cleanup;

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/iio-adc-ti-ads1015-enable-conversion-when-config_pm-is-not-set.patch queue-4.12/iio-adc-ti-ads1015-add-adequate-wait-time-to-get-correct-conversion.patch queue-4.12/iio-adc-ti-ads1015-don-t-return-invalid-value-from-buffer-setup-callbacks.patch queue-4.12/iio-adc-ti-ads1015-fix-incorrect-data-rate-setting-update.patch queue-4.12/iio-adc-ti-ads1015-fix-scale-information-for-ads1115.patch queue-4.12/iio-adc-ti-ads1015-avoid-getting-stale-result-after-runtime-resume.patch