Patch "binder: free memory on error" has been added to the 4.13-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
binder: free memory on error
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
binder-free-memory-on-error.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
22eb9476b5d80a393ac0ba235c42bccc90b82c76Mon Sep 17 00:00:00 2001
From: Christian Brauner <[email protected]>
Date: Mon, 21 Aug 2017 16:13:28 +0200
Subject: binder: free memory on error
From: Christian Brauner <[email protected]>
commit 22eb9476b5d80a393ac0ba235c42bccc90b82c76 upstream.
On binder_init() the devices string is duplicated and smashed into individual device names which are passed along. However, the original duplicated string wasn't freed in case binder_init() failed. Let's free it on error.
--- drivers/android/binder.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/android/binder.c +6 -2
@@ -4215,7 +4215,7 @@ static int __init init_binder_device(constatic int __init binder_init (void ) {int ret; -char *device_name, *device_names; +char *device_name, *device_names, *device_tmp;struct binder_device *device;struct hlist_node *tmp;
@@ -4263,7 +4263,8 @@ static int __init binder_init(void) }strcpy (device_names, binder_devices_param); -while ((device_name =strsep (&device_names,"," ))) { + device_tmp = device_names; +while ((device_name =strsep (&device_tmp,"," ))) { ret =init_binder_device (device_name);if (ret) goto err_init_binder_device_failed;
@@ -4277,6 +4278,9 @@ err_init_binder_device_failed:hlist_del (&device->hlist);kfree (device); } + +kfree (device_names); + err_alloc_device_names_failed:debugfs_remove_recursive (binder_debugfs_dir_entry_root);
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/binder-free-memory-on-error.patch