Skip to contentSkip to conversation

Staging:pi433:pi433_if.c:Fixes minor typo errors

PATCH In review harsha 3 participants 6 messages Sep 7, 2017 – Sep 8, 2017 Staging

lore
Share & tools
lore

harsha

author
#0 lore raw

PATCH 1/1 Staging:pi433:pi433_if.c:Fixes minor typo errors

Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/pi433/pi433_if.c +2 -2
index 6b9b7df..6a10478 100644
@@ -473,7 +473,7 @@ struct pi433_instance {
 	}
 
 
-	/* rx done, wait was interrupted or error occured */
+	/* rx done, wait was interrupted or error occurred */
 abort:
 	dev->interrupt_rx_allowed = true;
 	SET_CHECKED(rf69_set_mode(dev->spi, standby));
@@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
 		if (retval)
 			return retval;
 
-		dev_dbg(&device->spi->dev, "%s succesfully configured", name);
+		dev_dbg(&device->spi->dev, "%s successfully configured", name);
 	}
 
 	return 0;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · harsha

Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

Thanks for the patch. The change looks ok, but the subject line is not. Use git log --oneline on the affected file to see what others have done. In general, you cannot guess what the subject line should be. But in almost all cases, there is a space after each : and a filename, if it needs to be included, does not have an extension.

julia

Quoted 38 lines
---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/pi433/pi433_if.c +2 -3
index 6b9b7df..6a10478 100644
@@ -473,7 +473,7 @@ struct pi433_instance {
 	}
 
 
-	/* rx done, wait was interrupted or error occured */
+	/* rx done, wait was interrupted or error occurred */
 abort:
 	dev->interrupt_rx_allowed = true;
 	SET_CHECKED(rf69_set_mode(dev->spi, standby));
@@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
 		if (retval)
 			return retval;
 
-		dev_dbg(&device->spi->dev, "%s succesfully configured", name);
+		dev_dbg(&device->spi->dev, "%s successfully configured", name);
 	}
 
 	return 0;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504816316-9331-1-git-send-email-harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
In reply to harsha
Quoted 32 lines · Harsha Sharma

Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

---

 drivers/staging/pi433/pi433_if.c | 4 ++-- 
 1 file changed, 2 insertions(+), 2 deletions(-) 
drivers/staging/pi433/pi433_if.c +2 -2
index 6b9b7df..6a10478 100644 
@@ -473,7 +473,7 @@ struct pi433_instance { 
         } 
 
 
-        /* rx done, wait was interrupted or error occured */ 
+        /* rx done, wait was interrupted or error occurred */ 
 abort: 
         dev->interrupt_rx_allowed = true; 
         SET_CHECKED(rf69_set_mode(dev->spi, standby)); 
@@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device) 
                 if (retval) 
                         return retval; 
 
-                dev_dbg(&device->spi->dev, "%s succesfully configured", 
 name); 
+                dev_dbg(&device->spi->dev, "%s successfully configured", 
 name); 
         } 
Quoted 4 lines
         return 0; 
Signature · 1 line
1.9.1 

Hi,
Thanks a lot for your time.
I have changed the subject as you said.
Should I wait for this patch getting merged or can I send other patches ?

With Regards,
Harsha Sharma

#3 lore raw
Quoted 40 lines · Harsha Sharma

On Friday, September 8, 2017 at 2:03:58 AM UTC+5:30, Harsha Sharma wrote:

      Fixes checkpatch warning -- "occured" and "succesfully" are
      misspelled

      Signed-off-by: Harsha Sharma <[email protected]>
      ---
      ᅵdrivers/staging/pi433/pi433_if.c | 4 ++--
      ᅵ1 file changed, 2 insertions(+), 2 deletions(-)

      diff --git a/drivers/staging/pi433/pi433_if.c
      b/drivers/staging/pi433/pi433_if.c
      index 6b9b7df..6a10478 100644
      --- a/drivers/staging/pi433/pi433_if.c
      +++ b/drivers/staging/pi433/pi433_if.c
      @@ -473,7 +473,7 @@ struct pi433_instance {
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵ}
      ᅵ
      ᅵ
      -ᅵᅵᅵᅵᅵᅵᅵᅵ/* rx done, wait was interrupted or error occured */
      +ᅵᅵᅵᅵᅵᅵᅵᅵ/* rx done, wait was interrupted or error occurred */
      ᅵabort:
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵdev->interrupt_rx_allowed = true;
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵSET_CHECKED(rf69_set_mode(dev->spi, standby));
      @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device
      *device)
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵif (retval)
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵreturn retval;
      ᅵ
      -ᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵdev_dbg(&device->spi->dev, "%s succesfully
      configured", name);
      +ᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵdev_dbg(&device->spi->dev, "%s successfully
      configured", name);
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵ}
      ᅵ
      ᅵᅵᅵᅵᅵᅵᅵᅵᅵreturn 0;
      --
      1.9.1
Quoted 4 lines

Hi,
Thanks a lot for your time.
I have changed the subject as you said.ᅵ
Should I wait for this patch getting merged or can I send other patches ?

It's fine to send other patches immediately. But it would be better to work on other files, so that there is no confusion about whether one depends on another.

julia

Quoted 15 lines

With Regards,
Harsha Sharmaᅵ

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/28dc8f75-6844-473b-bd38- 60762296fdce%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

maintainer
#4 lore raw
Quoted 44 lines · Julia Lawall
Quoted 40 lines · Harsha Sharma

On Friday, September 8, 2017 at 2:03:58 AM UTC+5:30, Harsha Sharma wrote:

      Fixes checkpatch warning -- "occured" and "succesfully" are
      misspelled

      Signed-off-by: Harsha Sharma <[email protected]>
      ---
      �drivers/staging/pi433/pi433_if.c | 4 ++--
      �1 file changed, 2 insertions(+), 2 deletions(-)

      diff --git a/drivers/staging/pi433/pi433_if.c
      b/drivers/staging/pi433/pi433_if.c
      index 6b9b7df..6a10478 100644
      --- a/drivers/staging/pi433/pi433_if.c
      +++ b/drivers/staging/pi433/pi433_if.c
      @@ -473,7 +473,7 @@ struct pi433_instance {
      ���������}
      �
      �
      -��������/* rx done, wait was interrupted or error occured */
      +��������/* rx done, wait was interrupted or error occurred */
      �abort:
      ���������dev->interrupt_rx_allowed = true;
      ���������SET_CHECKED(rf69_set_mode(dev->spi, standby));
      @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device
      *device)
      �����������������if (retval)
      �������������������������return retval;
      �
      -����������������dev_dbg(&device->spi->dev, "%s succesfully
      configured", name);
      +����������������dev_dbg(&device->spi->dev, "%s successfully
      configured", name);
      ���������}
      �
      ���������return 0;
      --
      1.9.1
Quoted 8 lines
Quoted 4 lines

Hi,
Thanks a lot for your time.
I have changed the subject as you said.�
Should I wait for this patch getting merged or can I send other patches ?

It's fine to send other patches immediately. But it would be better to work on other files, so that there is no confusion about whether one depends on another.

Hm, this is going to get "interesting"...

Harsha's emails do not get through to me, due to their prior interactions on the driverdevel mailing list, which caused me to add them to my kill-file. So I don't have any patches to apply here :(

Harsha, given the prior interactions we had, what has changed to make it such that I should now be reviewing your patches? Last time I wasted a lot of time, and the feedback I provided was totally ignored, what is going to be different this time?

greg k-h

#5 lore raw

Hello Sir,
I'm really sorry for the last time. I tried to explain what I have done and sent the exactly same patch for reference.
I will hope that won't affect my upcoming journey in linux-kernel. I will try to be more clear and submit good patches.
Thanks a lot for your time.

With Regards,
Harsha Sharma

Quoted 69 lines · Greg KH
Quoted 7 lines · Julia Lawall
Quoted 3 lines · Harsha Sharma

On Friday, September 8, 2017 at 2:03:58 AM UTC+5:30, Harsha Sharma

Quoted 33 lines · wrote:
Quoted 33 lines
      Fixes checkpatch warning -- "occured" and "succesfully" are
      misspelled

      Signed-off-by: Harsha Sharma <[email protected]>
      ---
       drivers/staging/pi433/pi433_if.c | 4 ++--
       1 file changed, 2 insertions(+), 2 deletions(-)

      diff --git a/drivers/staging/pi433/pi433_if.c
      b/drivers/staging/pi433/pi433_if.c
      index 6b9b7df..6a10478 100644
      --- a/drivers/staging/pi433/pi433_if.c
      +++ b/drivers/staging/pi433/pi433_if.c
      @@ -473,7 +473,7 @@ struct pi433_instance {
               }


      -        /* rx done, wait was interrupted or error occured */
      +        /* rx done, wait was interrupted or error occurred */
       abort:
               dev->interrupt_rx_allowed = true;
               SET_CHECKED(rf69_set_mode(dev->spi, standby));
      @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device
      *device)
                       if (retval)
                               return retval;

      -                dev_dbg(&device->spi->dev, "%s succesfully
      configured", name);
      +                dev_dbg(&device->spi->dev, "%s successfully
      configured", name);
               }
Quoted 8 lines
Quoted 8 lines
               return 0;
      --
      1.9.1

Hi,
Thanks a lot for your time.
I have changed the subject as you said.
Should I wait for this patch getting merged or can I send other

patches ?

Quoted 4 lines

It's fine to send other patches immediately. But it would be better to work on other files, so that there is no confusion about whether one depends on another.

Hm, this is going to get "interesting"...

Harsha's emails do not get through to me, due to their prior interactions on the driverdevel mailing list, which caused me to add them to my kill-file. So I don't have any patches to apply here :(

Harsha, given the prior interactions we had, what has changed to make it such that I should now be reviewing your patches? Last time I wasted a lot of time, and the feedback I provided was totally ignored, what is going to be different this time?

greg k-h