staging: typec: tcpm: Comparison to NULL pointer
PATCH v2 1/1 staging: typec: tcpm: Comparison to NULL pointer
Makes code more concise and readable
---
Change in v2:
-Change in subject
-Change in log message
drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/typec/tcpm.c +1 -1
@@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload, } port->partner_altmode[pmdata->altmodes] =typec_partner_register_altmode (port->partner, paltmode); -if (port->partner_altmode[pmdata->altmodes] ==NULL ) { +if (!port->partner_altmode[pmdata->altmodes]) {tcpm_log (port,"Failed to register alternate modes for SVID 0x%04x" , paltmode->svid);
Signature · 1 line
1.9.1
Maybe "Rewrite comparison to NULL pointer" in the subject to include what was done, not just code was touched.
Quoted 1 line · Harsha Sharma
Makes code more concise and readable
Makes -> Make. Commit logs should be written in the imperative, like you are telling someone what to do.
julia
Quoted 31 lines
Signed-off-by Harsha Sharma <[email protected]>---
Change in v2:
-Change in subject
-Change in log messagedrivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/typec/tcpm.c +1
-2@@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload, } port->partner_altmode[pmdata->altmodes] =typec_partner_register_altmode (port->partner, paltmode); -if (port->partner_altmode[pmdata->altmodes] ==NULL ) { +if (!port->partner_altmode[pmdata->altmodes]) {tcpm_log (port,"Failed to register alternate modes for SVID 0x%04x" , paltmode->svid); --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504892391-5607-1-git-send-email-harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.