Skip to contentSkip to conversation

Request for review for 4.19-st13, 4.19-cip129

DISCUSSION Ulrich Hecht 3 participants 4 messages Feb 20 – Feb 23

lore
Share & tools
lore
#0 lore raw

Hi!

Here are the manual backports for the upcoming 4.19 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.19.y-st-rc

797ce10e2a2f1 macvlan: fix possible UAF in macvlan_forward_source() 85f1f9ce40bf7 HID: uclogic: Correct devm device reference for hidinput input_dev name 0c110bc67bd3d xfs: set max_agbno to allow sparse alloc of last full inode chunk 6a8957a06bc31 l2tp: avoid one data-race in l2tp_tunnel_del_work()

Thanks for having a look!

CU
Uli

#1 lore raw

Hi!

Quoted 2 lines

Here are the manual backports for the upcoming 4.19 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.19.y-st-rc

a > 797ce10e2a2f1 macvlan: fix possible UAF in macvlan_forward_source()
a > 85f1f9ce40bf7 HID: uclogic: Correct devm device reference for hidinput input_dev name a > 0c110bc67bd3d xfs: set max_agbno to allow sparse alloc of last full inode chunk a > 6a8957a06bc31 l2tp: avoid one data-race in l2tp_tunnel_del_work()

Quoted 1 line

Thank you, this series looks okay to me.

Best regards,
Pavel

Signature · 1 line
In cooperation with Nabla.
#2 lore raw
In reply to Ulrich Hecht

Hi Uli,

The following commit requires a fix. Enabling the driver will cause a build error.

c85bc75effc21 fbdev: ssd1307fb: fix potential page leak in ssd1307fb_probe()

```
drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe':
drivers/video/fbdev/ssd1307fb.c:726:22: error: passing argument 1 of
'__free_pages' from incompatible pointer type
[-Werror=incompatible-pointer-types]
  726 |         __free_pages(vmem, get_order(vmem_size));
      |                      ^~~~
      |                      |
      |                      u8 * {aka unsigned char *}
In file included from ./include/linux/idr.h:16,
                 from ./include/linux/kernfs.h:14,
                 from ./include/linux/sysfs.h:16,
                 from ./include/linux/kobject.h:20,
                 from ./include/linux/device.h:16,
                 from ./include/linux/backlight.h:12,
                 from drivers/video/fbdev/ssd1307fb.c:9:
./include/linux/gfp.h:566:39: note: expected 'struct page *' but
argument is of type 'u8 *' {aka 'unsigned char *'}     566 | extern
void __free_pages(struct page *page, unsigned int order);
      |                          ~~~~~~~~~~~~~^~~~
```

This can be fixed by cast to vmem.

```
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 8217910980487..20e83145fbacf 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -723,7 +723,7 @@ static int ssd1307fb_probe(struct i2c_client *client,
 reset_oled_error:
        fb_deferred_io_cleanup(info);
 fb_defio_error:
-       __free_pages(vmem, get_order(vmem_size));
+       __free_pages((void *)vmem, get_order(vmem_size));
 fb_alloc_error:
        framebuffer_release(info);
        return ret;
```

Best regards,
Nobuhiro

2026年2月20日(金) 15:39 Ulrich Hecht via lists.cip-project.org <[email protected]>:

Quoted 15 lines

Hi!

Here are the manual backports for the upcoming 4.19 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.19.y-st-rc

797ce10e2a2f1 macvlan: fix possible UAF in macvlan_forward_source() 85f1f9ce40bf7 HID: uclogic: Correct devm device reference for hidinput input_dev name 0c110bc67bd3d xfs: set max_agbno to allow sparse alloc of last full inode chunk 6a8957a06bc31 l2tp: avoid one data-race in l2tp_tunnel_del_work()

Thanks for having a look!

CU
Uli

Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#21902): https://lists.cip-project.org/g/cip-dev/message/21902
Mute This Topic: https://lists.cip-project.org/mt/117906404/4520494
Group Owner: [email protected]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
Nobuhiro Iwamatsu

#3 lore raw
Quoted 30 lines · CET Nobuhiro Iwamatsu via lists.cip-project.org

Hi Uli,

The following commit requires a fix. Enabling the driver will cause a build error.

c85bc75effc21 fbdev: ssd1307fb: fix potential page leak in ssd1307fb_probe()

```
drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe':
drivers/video/fbdev/ssd1307fb.c:726:22: error: passing argument 1 of
'__free_pages' from incompatible pointer type
[-Werror=incompatible-pointer-types]
  726 |         __free_pages(vmem, get_order(vmem_size));
      |                      ^~~~
      |                      |
      |                      u8 * {aka unsigned char *}
In file included from ./include/linux/idr.h:16,
                 from ./include/linux/kernfs.h:14,
                 from ./include/linux/sysfs.h:16,
                 from ./include/linux/kobject.h:20,
                 from ./include/linux/device.h:16,
                 from ./include/linux/backlight.h:12,
                 from drivers/video/fbdev/ssd1307fb.c:9:
./include/linux/gfp.h:566:39: note: expected 'struct page *' but
argument is of type 'u8 *' {aka 'unsigned char *'}     566 | extern
void __free_pages(struct page *page, unsigned int order);
      |                          ~~~~~~~~~~~~~^~~~
```
Quoted 1 line

This can be fixed by cast to vmem.

Fixed, thanks!

CU
Uli