Skip to contentSkip to conversation

Patch "nvme-fabrics: generate spec-compliant UUID NQNs" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Sep 10, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

nvme-fabrics: generate spec-compliant UUID NQNs

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nvme-fabrics-generate-spec-compliant-uuid-nqns.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 40a5fce495715c48c2e02668144e68a507ac5a30 Mon Sep 17 00:00:00 2001

From: Daniel Verkamp <[email protected]>
Date: Wed, 30 Aug 2017 15:18:19 -0700
Subject: nvme-fabrics: generate spec-compliant UUID NQNs

From: Daniel Verkamp <[email protected]>

commit 40a5fce495715c48c2e02668144e68a507ac5a30 upstream.

The default host NQN, which is generated based on the host's UUID, does not follow the UUID-based NQN format laid out in the NVMe 1.3 specification. Remove the "NVMf:" portion of the NQN to match the spec.

---
 drivers/nvme/host/fabrics.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/fabrics.c +1 -1
@@ -77,7 +77,7 @@ static struct nvmf_host *nvmf_host_defau
 	kref_init(&host->ref);
 	uuid_be_gen(&host->id);
 	snprintf(host->nqn, NVMF_NQN_SIZE,
-		"nqn.2014-08.org.nvmexpress:NVMf:uuid:%pUb", &host->id);
+		"nqn.2014-08.org.nvmexpress:uuid:%pUb", &host->id);
 
 	mutex_lock(&nvmf_hosts_mutex);
 	list_add_tail(&host->list, &nvmf_hosts);

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/nvme-fabrics-generate-spec-compliant-uuid-nqns.patch