Skip to contentSkip to conversation

Patch "mm/sparse.c: fix typo in online_mem_sections" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Sep 10, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mm/sparse.c: fix typo in online_mem_sections

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mm-sparse.c-fix-typo-in-online_mem_sections.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b4ccec41af82b5a5518c6534444412961894f07c Mon Sep 17 00:00:00 2001

From: Michal Hocko <[email protected]>
Date: Fri, 8 Sep 2017 16:13:15 -0700
Subject: mm/sparse.c: fix typo in online_mem_sections

From: Michal Hocko <[email protected]>

commit b4ccec41af82b5a5518c6534444412961894f07c upstream.

online_mem_sections() accidentally marks online only the first section in the given range. This is a typo which hasn't been noticed because I haven't tested large 2GB blocks previously. All users of pfn_to_online_page would get confused on the the rest of the pfn range in the block.

All we need to fix this is to use iterator (pfn) rather than start_pfn.

Fixes 2d070eab2e82 ("mm: consider zone which is not fully populated to have holes")
Cc Anshuman Khandual <[email protected]>
---
 mm/sparse.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/sparse.c +1 -1
@@ -630,7 +630,7 @@ void online_mem_sections(unsigned long s
 	unsigned long pfn;
 
 	for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
-		unsigned long section_nr = pfn_to_section_nr(start_pfn);
+		unsigned long section_nr = pfn_to_section_nr(pfn);
 		struct mem_section *ms;
 
 		/* onlining code should never touch invalid ranges */

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/mm-memory.c-fix-mem_cgroup_oom_disable-call-missing.patch queue-4.13/mm-sparse.c-fix-typo-in-online_mem_sections.patch