Skip to contentSkip to conversation

sparc64: mmu_context: Add missing include files

PATCH Applied Guenter Roeck 3 participants 5 messages Sep 10, 2017 – Oct 26, 2017 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore

Guenter Roeck

author
#0 lore raw

PATCH 1/1 sparc64: mmu_context: Add missing include files

Fix the following build errors.

In file included from arch/sparc/include/asm/mmu_context.h:4:0,
from include/linux/mmu_context.h:4,
from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h:29, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:23:
arch/sparc/include/asm/mmu_context_64.h:22:37: error:
unknown type name 'per_cpu_secondary_mm'

arch/sparc/include/asm/mmu_context_64.h: In function 'switch_mm':
arch/sparc/include/asm/mmu_context_64.h:79:2: error:
implicit declaration of function 'smp_processor_id'

Fixes 70539bd79500 ("drm/amd: Update MEC HQD loading code for KFD")
Signed-off-by Guenter Roeck <[email protected]>

---
"Exposed-by:" instead of "Fixes:" might be more appropriate.

 arch/sparc/include/asm/mmu_context_64.h | 2 ++
 1 file changed, 2 insertions(+)
arch/sparc/include/asm/mmu_context_64.h +2 -0
index 87841d687f8d..a34315e1f0ed 100644
@@ -7,9 +7,11 @@
 
 #include <linux/spinlock.h>
 #include <linux/mm_types.h>
+#include <linux/smp.h>
 
 #include <asm/spitfire.h>
 #include <asm-generic/mm_hooks.h>
+#include <asm/percpu.h>
 
 static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
 {
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 38 lines · Guenter Roeck

Fix the following build errors.

In file included from arch/sparc/include/asm/mmu_context.h:4:0,
from include/linux/mmu_context.h:4,
from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h:29, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:23:
arch/sparc/include/asm/mmu_context_64.h:22:37: error:
unknown type name 'per_cpu_secondary_mm'

arch/sparc/include/asm/mmu_context_64.h: In function 'switch_mm':
arch/sparc/include/asm/mmu_context_64.h:79:2: error:
implicit declaration of function 'smp_processor_id'

Fixes 70539bd79500 ("drm/amd: Update MEC HQD loading code for KFD")
Signed-off-by Guenter Roeck <[email protected]>

---
"Exposed-by:" instead of "Fixes:" might be more appropriate.

 arch/sparc/include/asm/mmu_context_64.h | 2 ++
 1 file changed, 2 insertions(+)
arch/sparc/include/asm/mmu_context_64.h +2 -1
index 87841d687f8d..a34315e1f0ed 100644
@@ -7,9 +7,11 @@
 
 #include <linux/spinlock.h>
 #include <linux/mm_types.h>
+#include <linux/smp.h>
 
 #include <asm/spitfire.h>
 #include <asm-generic/mm_hooks.h>
+#include <asm/percpu.h>
 
 static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
 {
--
Quoted 2 lines

2.7.4

This patch is:

Acked-by Oded Gabbay <[email protected]>

HI David,
Could you please pick-up this patch for -rc3/4 ? We constantly get kbuild error reports due to this issue.

Thanks,
Oded

maintainer
#2 lore raw

From: Oded Gabbay <[email protected]>
Date: Sun, 24 Sep 2017 13:14:01 +0300

Quoted 2 lines

Could you please pick-up this patch for -rc3/4 ? We constantly get kbuild error reports due to this issue.

I sure will.

maintainer Applied
#3 lore raw
In reply to Guenter Roeck

From: Guenter Roeck <[email protected]>
Date: Sun, 10 Sep 2017 13:44:47 -0700

Quoted 9 lines

Fix the following build errors.

In file included from arch/sparc/include/asm/mmu_context.h:4:0,
from include/linux/mmu_context.h:4,
from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h:29, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:23:
arch/sparc/include/asm/mmu_context_64.h:22:37: error:
unknown type name 'per_cpu_secondary_mm'

Quoted 6 lines

arch/sparc/include/asm/mmu_context_64.h: In function 'switch_mm':
arch/sparc/include/asm/mmu_context_64.h:79:2: error:
implicit declaration of function 'smp_processor_id'

Fixes 70539bd79500 ("drm/amd: Update MEC HQD loading code for KFD")
Signed-off-by Guenter Roeck <[email protected]>

Applied.

author
#4 lore raw
In reply to Guenter Roeck

Did I send this to the wrong mailing list, or did it get lost ? Should I resend ?

Guenter

Quoted 38 lines · Guenter Roeck

Fix the following build errors.

In file included from arch/sparc/include/asm/mmu_context.h:4:0,
from include/linux/mmu_context.h:4,
from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h:29, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:23:
arch/sparc/include/asm/mmu_context_64.h:22:37: error:
unknown type name 'per_cpu_secondary_mm'

arch/sparc/include/asm/mmu_context_64.h: In function 'switch_mm':
arch/sparc/include/asm/mmu_context_64.h:79:2: error:
implicit declaration of function 'smp_processor_id'

Fixes 70539bd79500 ("drm/amd: Update MEC HQD loading code for KFD")
Signed-off-by Guenter Roeck <[email protected]>
Acked-by Oded Gabbay <[email protected]>

---
"Exposed-by:" instead of "Fixes:" might be more appropriate.

 arch/sparc/include/asm/mmu_context_64.h | 2 ++
 1 file changed, 2 insertions(+)
arch/sparc/include/asm/mmu_context_64.h +2 -0
index 87841d687f8d..a34315e1f0ed 100644
@@ -7,9 +7,11 @@
 
 #include <linux/spinlock.h>
 #include <linux/mm_types.h>
+#include <linux/smp.h>
 
 #include <asm/spitfire.h>
 #include <asm-generic/mm_hooks.h>
+#include <asm/percpu.h>
 
 static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
 {