Patch "net/mlx5: E-Switch, Unload the representors in the correct order" has been added to the 4.12-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net/mlx5: E-Switch, Unload the representors in the correct order
to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-mlx5-e-switch-unload-the-representors-in-the-correct-order.patch
and it can be found in the queue-4.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Sep 14 23:20:23 PDT 2017
From: Shahar Klein <[email protected]>
Date: Tue, 1 Aug 2017 15:29:55 +0300
Subject: net/mlx5: E-Switch, Unload the representors in the correct order
From: Shahar Klein <[email protected]>
[ Upstream commit 191220396db840822fc818edf03c49f0c02eb237 ]
When changing from switchdev to legacy mode, all the representor port devices (uplink nic and reps) are cleaned up. Part of this cleaning process is removing the neigh entries and the hash table containing them. However, a representor neigh entry might be linked to the uplink port hash table and if the uplink nic is cleaned first the cleaning of the representor will end up in null deref.
Fix that by unloading the representors in the opposite order of load.
--- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +1 -1
@@ -818,7 +818,7 @@ void esw_offloads_cleanup(struct mlx5_esstruct mlx5_eswitch_rep *rep;int vport; -for (vport =0 ; vport < nvports; vport++) { +for (vport = nvports -1 ; vport >=0 ; vport--) { rep = &esw->offloads.vport_reps[vport];if (!rep->valid)continue ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.12/net-mlx5-e-switch-unload-the-representors-in-the-correct-order.patch