Skip to contentSkip to conversation

Staging: dgnc: Remove unused variables from structure definition

PATCH In review Srishti Sharma 2 participants 5 messages Sep 16, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: dgnc: Remove unused variables from structure definition

Some variables in the structure were unused and hence them and the comments associated with them can be removed.

---
 drivers/staging/dgnc/dgnc_driver.h | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/dgnc/dgnc_driver.h +0 -10
index 764d6fe..2b625cc 100644
@@ -103,8 +103,6 @@ struct board_ops {
 /**
  * struct dgnc_board - Per board information.
  * @boardnum: Board number (0 - 32).
- *
- * @type: Type of board.
  * @name: Product name.
  * @pdev: Pointer to the pci_dev structure.
  * @bd_flags: Board flags.
@@ -140,13 +138,9 @@ struct board_ops {
  * @dpastatus: Board status as defined by DPA.
  * @bd_dividend: Board/UART's specific dividend.
  * @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
  */
 struct dgnc_board {
 	int		boardnum;
-
-	int		type;
 	char		*name;
 	struct pci_dev	*pdev;
 	unsigned long	bd_flags;
@@ -200,10 +194,6 @@ struct dgnc_board {
 	uint		bd_dividend;
 
 	struct board_ops *bd_ops;
-
-	struct proc_dir_entry *proc_entry_pointer;
-	struct dgnc_proc_entry *dgnc_board_table;
-
 };
 
 /* Unit flag definitions for un_flags. */
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Srishti Sharma

Some variables in the structure were unused and hence them and the comments associated with them can be removed.

How did you find these? The last two can easily be checked with grep, but that is ont the case for type.

Actually there are two structures in the file with useless proc_entry_pointer fields. The other one has a useless dgnc_channel_table. It could be reasonable to make a series to do both structures.

julia

Quoted 54 lines
---
 drivers/staging/dgnc/dgnc_driver.h | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/dgnc/dgnc_driver.h +0 -11
index 764d6fe..2b625cc 100644
@@ -103,8 +103,6 @@ struct board_ops {
 /**
  * struct dgnc_board - Per board information.
  * @boardnum: Board number (0 - 32).
- *
- * @type: Type of board.
  * @name: Product name.
  * @pdev: Pointer to the pci_dev structure.
  * @bd_flags: Board flags.
@@ -140,13 +138,9 @@ struct board_ops {
  * @dpastatus: Board status as defined by DPA.
  * @bd_dividend: Board/UART's specific dividend.
  * @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
  */
 struct dgnc_board {
 	int		boardnum;
-
-	int		type;
 	char		*name;
 	struct pci_dev	*pdev;
 	unsigned long	bd_flags;
@@ -200,10 +194,6 @@ struct dgnc_board {
 	uint		bd_dividend;
 
 	struct board_ops *bd_ops;
-
-	struct proc_dir_entry *proc_entry_pointer;
-	struct dgnc_proc_entry *dgnc_board_table;
-
 };
 
 /* Unit flag definitions for un_flags. */
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505562186-11813-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 9 lines · Julia Lawall
Quoted 2 lines · Srishti Sharma

Some variables in the structure were unused and hence them and the comments associated with them can be removed.

How did you find these? The last two can easily be checked with grep, but that is ont the case for type.

I removed them and then compiled the code to see if it still compiles. I was using grep earlier to see if the fields in the structure are ever accessed by the variables of that structure type, as the TODO of the driver says that there is a lot of unneeded code.

Quoted 5 lines

Actually there are two structures in the file with useless proc_entry_pointer fields. The other one has a useless dgnc_channel_table. It could be reasonable to make a series to do both structures.

Okay, I'll send them as a series. Thanks

Regards,
Srishti

Quoted 56 lines

julia

Quoted 54 lines
---
 drivers/staging/dgnc/dgnc_driver.h | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/dgnc/dgnc_driver.h +0 -11
index 764d6fe..2b625cc 100644
@@ -103,8 +103,6 @@ struct board_ops {
 /**
  * struct dgnc_board - Per board information.
  * @boardnum: Board number (0 - 32).
- *
- * @type: Type of board.
  * @name: Product name.
  * @pdev: Pointer to the pci_dev structure.
  * @bd_flags: Board flags.
@@ -140,13 +138,9 @@ struct board_ops {
  * @dpastatus: Board status as defined by DPA.
  * @bd_dividend: Board/UART's specific dividend.
  * @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
  */
 struct dgnc_board {
      int             boardnum;
-
-     int             type;
      char            *name;
      struct pci_dev  *pdev;
      unsigned long   bd_flags;
@@ -200,10 +194,6 @@ struct dgnc_board {
      uint            bd_dividend;
 
      struct board_ops *bd_ops;
-
-     struct proc_dir_entry *proc_entry_pointer;
-     struct dgnc_proc_entry *dgnc_board_table;
-
 };
 
 /* Unit flag definitions for un_flags. */
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505562186-11813-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#3 lore raw
Quoted 5 lines · Srishti Sharma
Quoted 4 lines · Julia Lawall

On Sat, 16 Sep 2017, Srishti Sharma wrote:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Some variables in the structure were unused and hence them and the comments associated with them can be removed.

How did you find these? The last two can easily be checked with grep, but that is ont the case for type.

I removed them and then compiled the code to see if it still compiles.

This is not 100% reliable because of the possibility of uses inside ifdefs. So you need to double check that you have found every occurrence of the structure type for the type field. The others seem not dangerous.

julia

Quoted 71 lines

I was using grep earlier to see if the fields in the structure are ever accessed by the variables of that structure type, as the TODO of the driver says that there is a lot of unneeded code.

Quoted 5 lines

Actually there are two structures in the file with useless proc_entry_pointer fields. The other one has a useless dgnc_channel_table. It could be reasonable to make a series to do both structures.

Okay, I'll send them as a series. Thanks

Regards,
Srishti

Quoted 56 lines

julia

Quoted 54 lines
---
 drivers/staging/dgnc/dgnc_driver.h | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/dgnc/dgnc_driver.h +0 -11
index 764d6fe..2b625cc 100644
@@ -103,8 +103,6 @@ struct board_ops {
 /**
  * struct dgnc_board - Per board information.
  * @boardnum: Board number (0 - 32).
- *
- * @type: Type of board.
  * @name: Product name.
  * @pdev: Pointer to the pci_dev structure.
  * @bd_flags: Board flags.
@@ -140,13 +138,9 @@ struct board_ops {
  * @dpastatus: Board status as defined by DPA.
  * @bd_dividend: Board/UART's specific dividend.
  * @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
  */
 struct dgnc_board {
      int             boardnum;
-
-     int             type;
      char            *name;
      struct pci_dev  *pdev;
      unsigned long   bd_flags;
@@ -200,10 +194,6 @@ struct dgnc_board {
      uint            bd_dividend;
 
      struct board_ops *bd_ops;
-
-     struct proc_dir_entry *proc_entry_pointer;
-     struct dgnc_proc_entry *dgnc_board_table;
-
 };
 
 /* Unit flag definitions for un_flags. */
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505562186-11813-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#4 lore raw
Quoted 12 lines · Julia Lawall
Quoted 8 lines · Srishti Sharma
Quoted 7 lines · Julia Lawall
Quoted 2 lines · Srishti Sharma

Some variables in the structure were unused and hence them and the comments associated with them can be removed.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

How did you find these? The last two can easily be checked with grep, but that is ont the case for type.

I removed them and then compiled the code to see if it still compiles.

This is not 100% reliable because of the possibility of uses inside ifdefs. So you need to double check that you have found every occurrence of the structure type for the type field. The others seem not dangerous.

Okay, I'll do that . Thanks

Srishti

Quoted 74 lines

julia

Quoted 71 lines

I was using grep earlier to see if the fields in the structure are ever accessed by the variables of that structure type, as the TODO of the driver says that there is a lot of unneeded code.

Quoted 5 lines

Actually there are two structures in the file with useless proc_entry_pointer fields. The other one has a useless dgnc_channel_table. It could be reasonable to make a series to do both structures.

Okay, I'll send them as a series. Thanks

Regards,
Srishti

Quoted 56 lines

julia

Quoted 54 lines
---
 drivers/staging/dgnc/dgnc_driver.h | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/dgnc/dgnc_driver.h +0 -11
index 764d6fe..2b625cc 100644
@@ -103,8 +103,6 @@ struct board_ops {
 /**
  * struct dgnc_board - Per board information.
  * @boardnum: Board number (0 - 32).
- *
- * @type: Type of board.
  * @name: Product name.
  * @pdev: Pointer to the pci_dev structure.
  * @bd_flags: Board flags.
@@ -140,13 +138,9 @@ struct board_ops {
  * @dpastatus: Board status as defined by DPA.
  * @bd_dividend: Board/UART's specific dividend.
  * @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
  */
 struct dgnc_board {
      int             boardnum;
-
-     int             type;
      char            *name;
      struct pci_dev  *pdev;
      unsigned long   bd_flags;
@@ -200,10 +194,6 @@ struct dgnc_board {
      uint            bd_dividend;
 
      struct board_ops *bd_ops;
-
-     struct proc_dir_entry *proc_entry_pointer;
-     struct dgnc_proc_entry *dgnc_board_table;
-
 };
 
 /* Unit flag definitions for un_flags. */
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505562186-11813-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.