Skip to contentSkip to conversation

drm/i915: Return the correct score in i915_ppat_get()

PATCH In review Zhi Wang 2 participants 3 messages Sep 18, 2017

Subsystems (2)
lore
Share & tools
lore

Zhi Wang

author
#0 lore raw

PATCH 1/1 drm/i915: Return the correct score in i915_ppat_get()

The cache attribute of the required entry has to be the same with the existing value. After this requirement is met, the futher comparison should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc Chris Wilson <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +1 -1
index 5923b51..636ad7d 100644
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
 	};
 
 	/* Cache attribute has to be matched. */
-	if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+	if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
 		return 0;
 
 	score |= CA_MATCH;
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Zhi Wang (2017-09-18 14:36:34)

Quoted 8 lines

The cache attribute of the required entry has to be the same with the existing value. After this requirement is met, the futher comparison should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Quoted 7 lines
Fixes 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc Chris Wilson <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Joonas Lahtinen <[email protected]>

And pushed, thanks for the followup.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Sorry for the trouble. :(

-----Original Message-----
From: intel-gvt-dev [mailto:[email protected]] On Behalf Of Chris Wilson
Sent: Monday, September 18, 2017 6:03 PM
To: Wang, Zhi A <[email protected]>; [email protected]; [email protected]
Cc: Vivi, Rodrigo <[email protected]>; [email protected]; Wang, Zhi A <[email protected]>; [email protected]; Widawsky, Benjamin <[email protected]>
Subject: Re: [PATCH] drm/i915: Return the correct score in i915_ppat_get()

Quoting Zhi Wang (2017-09-18 14:36:34)

Quoted 8 lines

The cache attribute of the required entry has to be the same with the existing value. After this requirement is met, the futher comparison should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Quoted 7 lines
Fixes 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc Chris Wilson <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Joonas Lahtinen <[email protected]>

And pushed, thanks for the followup.
-Chris
_______________________________________________
intel-gvt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx