patch "usb: xhci: Free the right ring in xhci_add_endpoint()" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: xhci: Free the right ring in xhci_add_endpoint()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
9821786d7c90eee2f6852261893d9703801aae47Mon Sep 17 00:00:00 2001
From: Lu Baolu <[email protected]>
Date: Mon, 18 Sep 2017 17:39:12 +0300
Subject: usb: xhci: Free the right ring in xhci_add_endpoint()
In the xhci_add_endpoint(), a new ring was allocated and saved at xhci_virt_ep->new_ring. Hence, when error happens, we need to free the allocated ring before returning error.
Current code frees xhci_virt_ep->ring instead of the new_ring. This patch fixes this.
--- drivers/usb/host/xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/xhci.c +2 -1
@@ -1703,7 +1703,8 @@ static int xhci_add_endpoint(struct usb_hcd *hcd, struct usb_device *udev,if (xhci->quirks &XHCI_MTK_HOST ) { ret =xhci_mtk_add_ep_quirk (hcd, udev, ep);if (ret <0 ) { -xhci_free_endpoint_ring (xhci, virt_dev, ep_index); +xhci_ring_free (xhci, virt_dev->eps[ep_index].new_ring); + virt_dev->eps[ep_index].new_ring =NULL ;return ret; } }
Signature · 1 line
2.14.1