drm/i915/cnl: Add Gen10 LRC size
Subsystems (2)
PATCH 1/1 drm/i915/cnl: Add Gen10 LRC size
The total size of the context has decreased with the removal of the URB_ATOMIC section. BSpec indicates 16750 DWORDs (17 pages), plus one page for PPHWSP, and I'm throwing an extra page for precaution.
--- drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_engine_cs.c +2 -0
@@ -39,6 +39,7 @@#define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)#define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) +#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
@@ -150,6 +151,7 @@ struct engine_info {default :MISSING_CASE (INTEL_GEN (dev_priv));case 10 : +return GEN10_LR_CONTEXT_RENDER_SIZE ;case 9 :return GEN9_LR_CONTEXT_RENDER_SIZE ;case 8 :
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/cnl: Add Gen10 LRC size
== Series Details ==
== Series Details ==
Series: drm/i915/cnl: Add Gen10 LRC size
URL : https://patchwork.freedesktop.org/series/30724/
State : success
== Summary ==
Series 30724v1 drm/i915/cnl: Add Gen10 LRC size
https://patchwork.freedesktop.org/api/1.0/series/30724/revisions/1/mbox/
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:448s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:471s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:418s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:522s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:278s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:503s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:489s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:491s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:542s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:423s fi-glk-1 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:565s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:426s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:405s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:433s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:481s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:459s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:472s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:590s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:542s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:451s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:748s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:490s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:476s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:565s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:419s
b32248fc0bd87b45bc068f234f061324a29fa809 drm-tip: 2017y-09m-21d-22h-36m-39s UTC integration manifest a4ff41c55dab drm/i915/cnl: Add Gen10 LRC size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5787/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/cnl: Add Gen10 LRC size
In reply to Oscar Mateo== Series Details ==
== Series Details ==
Series: drm/i915/cnl: Add Gen10 LRC size
URL : https://patchwork.freedesktop.org/series/30724/
State : success
== Summary ==
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2429 pass:1329 dwarn:6 dfail:0 fail:11 skip:1083 time:9748s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5787/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Oscar Mateo
The total size of the context has decreased with the removal of the
URB_ATOMICsection. BSpec indicates 16750 DWORDs (17 pages), plus one page for PPHWSP, and I'm throwing an extra page for precaution.
I could never find this info on bspec... could you please point that to me?
Anyways this value matches with other HW engineers had told me a while ago, and we now have CNL on CI, so:
Quoted 32 lines
Signed-off-by Oscar Mateo <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Ben Widawsky <[email protected]>--- drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_engine_cs.c +2
-0@@ -39,6 +39,7 @@#define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)#define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) +#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)@@ -150,6 +151,7 @@ struct engine_info {default :MISSING_CASE (INTEL_GEN (dev_priv));case 10 : +return GEN10_LR_CONTEXT_RENDER_SIZE ;case 9 :return GEN9_LR_CONTEXT_RENDER_SIZE ;case 8 :Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Rodrigo Vivi
Quoted 3 lines · Oscar Mateo
The total size of the context has decreased with the removal of the
URB_ATOMICsection. BSpec indicates 16750 DWORDs (17 pages), plus one page for PPHWSP, and I'm throwing an extra page for precaution.I could never find this info on bspec... could you please point that to me?
Michal already pointed the doc to me!
Now I know where that comes from! :)
Patch Merges to dinq.
Thanks
Quoted 28 lines
Anyways this value matches with other HW engineers had told me a while ago, and we now have CNL on CI, so:
Acked-by Rodrigo Vivi <[email protected]>Review
Quoted 10 lines
Signed-off-by Oscar Mateo <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Ben Widawsky <[email protected]>--- drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ 1 file changed, 2 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_engine_cs.cQuoted 11 lines
index 3d135c3..a3115f3 100644
drivers/gpu/drm/i915/intel_engine_cs.c +1
-0@@ -39,6 +39,7 @@#define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)#define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) +#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
Quoted 16 lines
Quoted 11 lines
drivers/gpu/drm/i915/intel_engine_cs.c +1
-1@@ -150,6 +151,7 @@ struct engine_info {default :MISSING_CASE (INTEL_GEN (dev_priv));case 10 : +return GEN10_LR_CONTEXT_RENDER_SIZE ;case 9 :return GEN9_LR_CONTEXT_RENDER_SIZE ;case 8 : --1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
maintainerQuoted 3 lines · Oscar Mateo
The total size of the context has decreased with the removal of the
URB_ATOMICsection. BSpec indicates 16750 DWORDs (17 pages), plus one page for PPHWSP, and I'm throwing an extra page for precaution.
Rather no precaution, or make it for all gens and add a comment.
It's otherwise super confusing to double-check the correctness, been there, done that :)
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx