Skip to contentSkip to conversation

default-providers: set pkgconf as the preferred provider for pkg-config

PATCH In review Maxin B. John 3 participants 3 messages Sep 24, 2017 – Sep 25, 2017

lore
Share & tools
lore

Maxin B. John

author
#0 lore raw

PATCH 1/1 default-providers: set pkgconf as the preferred provider for pkg-config

Replace system pkg-config implementation with pkgconf

[YOCTO #11308]

Signed-off-by Maxin B. John <[email protected]>
---
 meta/conf/distro/include/default-providers.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/distro/include/default-providers.inc +3 -3
index f54fdcd..f441d74 100644
@@ -53,6 +53,6 @@ PREFERRED_PROVIDER_getopt ?= "util-linux-getopt"
 PREFERRED_PROVIDER_openssl ?= "openssl"
 PREFERRED_PROVIDER_openssl-native ?= "openssl-native"
 PREFERRED_PROVIDER_nativesdk-openssl ?= "nativesdk-openssl"
-PREFERRED_PROVIDER_pkgconfig ?= "pkgconfig"
-PREFERRED_PROVIDER_nativesdk-pkgconfig ?= "nativesdk-pkgconfig"
-PREFERRED_PROVIDER_pkgconfig-native ?= "pkgconfig-native"
+PREFERRED_PROVIDER_pkgconfig ?= "pkgconf"
+PREFERRED_PROVIDER_nativesdk-pkgconfig ?= "nativesdk-pkgconf"
+PREFERRED_PROVIDER_pkgconfig-native ?= "pkgconf-native"
Signature · 1 line
2.4.0
#1 lore raw

meta/conf/distro/include/default-providers.inc PREFERRED_PROVIDER_getopt ?= "util-linux-getopt" · line 58

Quoted 10 lines · Maxin B. John
meta/conf/distro/include/default-providers.inc +3 -3
@@ -53,6 +53,6 @@ PREFERRED_PROVIDER_getopt ?= "util-linux-getopt"
  PREFERRED_PROVIDER_openssl ?= "openssl"
  PREFERRED_PROVIDER_openssl-native ?= "openssl-native"
  PREFERRED_PROVIDER_nativesdk-openssl ?= "nativesdk-openssl"
-PREFERRED_PROVIDER_pkgconfig ?= "pkgconfig"
-PREFERRED_PROVIDER_nativesdk-pkgconfig ?= "nativesdk-pkgconfig"
-PREFERRED_PROVIDER_pkgconfig-native ?= "pkgconfig-native"
+PREFERRED_PROVIDER_pkgconfig ?= "pkgconf"
+PREFERRED_PROVIDER_nativesdk-pkgconfig ?= "nativesdk-pkgconf"
+PREFERRED_PROVIDER_pkgconfig-native ?= "pkgconf-native"

Why not simply replace one with the other outright? Is there a benefit in providing both, or known issues with the newer implementation?

Alex

#2 lore raw
Quoted 8 lines · Alexander Kanavin

On 09/24/2017 11:21 PM, Maxin B. John wrote:

(quoted diff) +0 -0
@@ -53,6 +53,6 @@ PREFERRED_PROVIDER_getopt ?= "util-linux-getopt"
Quoted 5 lines

PREFERRED_PROVIDER_openssl ?= "openssl" PREFERRED_PROVIDER_openssl-native ?= "openssl-native" PREFERRED_PROVIDER_nativesdk-openssl ?= "nativesdk-openssl"

meta/conf/distro/include/default-providers.inc +0 -2
-PREFERRED_PROVIDER_pkgconfig ?= "pkgconfig"
-PREFERRED_PROVIDER_nativesdk-pkgconfig ?= "nativesdk-pkgconfig"
Quoted 9 lines

meta/conf/distro/include/default-providers.inc PREFERRED_PROVIDER_getopt ?= "util-linux-getopt" · line 58

Quoted 5 lines
meta/conf/distro/include/default-providers.inc +3 -1
-PREFERRED_PROVIDER_pkgconfig-native ?= "pkgconfig-native"
+PREFERRED_PROVIDER_pkgconfig ?= "pkgconf"
+PREFERRED_PROVIDER_nativesdk-pkgconfig ?= "nativesdk-pkgconf"
+PREFERRED_PROVIDER_pkgconfig-native ?= "pkgconf-native"

Why not simply replace one with the other outright? Is there a benefit in providing both, or known issues with the newer implementation?

Phased migration. We can run with this for a while (post Rocko, obviously) and then drop pkgconfig and add PROVIDES to pkgconf if it proves stable.

Ross