Skip to contentSkip to conversation

mx6: toradex: Remove custom CONFIG_SPL_PAD_TO definition

PATCH New Fabio Estevam 3 participants 3 messages Sep 25, 2017 – Oct 2, 2017 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 mx6: toradex: Remove custom CONFIG_SPL_PAD_TO definition

From: Fabio Estevam <[email protected]>

CONFIG_SPL_PAD_TO is already defined inside "imx6_spl.h", so there is no need to redefine it in the board config files.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/apalis_imx6.h  | 1 -
 include/configs/colibri_imx6.h | 1 -
 2 files changed, 2 deletions(-)
include/configs/apalis_imx6.h +0 -1
index a15f19d..51bf61c 100644
@@ -23,7 +23,6 @@
 
 #ifdef CONFIG_SPL
 #include "imx6_spl.h"
-#define CONFIG_SPL_PAD_TO		0x11000 /* 4k IVT/DCD, 64k SPL */
 #endif
 
 #define CONFIG_CMDLINE_TAG
include/configs/colibri_imx6.h +0 -1
index db71369..ac9a23d 100644
@@ -21,7 +21,6 @@
 
 #ifdef CONFIG_SPL
 #include "imx6_spl.h"
-#define CONFIG_SPL_PAD_TO		0x11000 /* 4k IVT/DCD, 64k SPL */
 #endif
 
 #define CONFIG_CMDLINE_TAG
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 mx6: toradex: Remove custom CONFIG_SPL_PAD_TO definition

Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_SPL_PAD_TO is already defined inside "imx6_spl.h", so there is no need to redefine it in the board config files.

That looks good to me.

Reviewed-by Stefan Agner <[email protected]>

--
Stefan

Quoted 31 lines
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/apalis_imx6.h  | 1 -
 include/configs/colibri_imx6.h | 1 -
 2 files changed, 2 deletions(-)
include/configs/apalis_imx6.h +0 -1
index a15f19d..51bf61c 100644
@@ -23,7 +23,6 @@
 
 #ifdef CONFIG_SPL
 #include "imx6_spl.h"
-#define CONFIG_SPL_PAD_TO		0x11000 /* 4k IVT/DCD, 64k SPL */
 #endif
 
 #define CONFIG_CMDLINE_TAG
include/configs/colibri_imx6.h +0 -1
index db71369..ac9a23d 100644
@@ -21,7 +21,6 @@
 
 #ifdef CONFIG_SPL
 #include "imx6_spl.h"
-#define CONFIG_SPL_PAD_TO		0x11000 /* 4k IVT/DCD, 64k SPL */
 #endif
 
 #define CONFIG_CMDLINE_TAG
#2 lore raw

PATCH 1/1 mx6: toradex: Remove custom CONFIG_SPL_PAD_TO definition

In reply to Fabio Estevam
Quoted 29 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_SPL_PAD_TO is already defined inside "imx6_spl.h", so there is no need to redefine it in the board config files.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/apalis_imx6.h  | 1 -
 include/configs/colibri_imx6.h | 1 -
 2 files changed, 2 deletions(-)
include/configs/apalis_imx6.h +0 -1
index a15f19d..51bf61c 100644
@@ -23,7 +23,6 @@
 
 #ifdef CONFIG_SPL
 #include "imx6_spl.h"
-#define CONFIG_SPL_PAD_TO		0x11000 /* 4k IVT/DCD, 64k SPL */
 #endif
 
 #define CONFIG_CMDLINE_TAG
include/configs/colibri_imx6.h +0 -0
index db71369..ac9a23d 100644

include/configs/colibri_imx6.h line 26

Quoted 7 lines
include/configs/colibri_imx6.h +0 -1
@@ -21,7 +21,6 @@
 
 #ifdef CONFIG_SPL
 #include "imx6_spl.h"
-#define CONFIG_SPL_PAD_TO		0x11000 /* 4k IVT/DCD, 64k SPL */
 #endif
 
 #define CONFIG_CMDLINE_TAG

Applied to u-boot-imx, -master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================