Skip to contentSkip to conversation

Patch "dm-raid: fix a race condition in request handling" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 2 messages Oct 2, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

dm-raid: fix a race condition in request handling

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
dm-raid-fix-a-race-condition-in-request-handling.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c4d6a1b8e8ea79c439a4871cba540443c9eb13b9 Mon Sep 17 00:00:00 2001

From: Shaohua Li <[email protected]>
Date: Thu, 21 Sep 2017 10:29:22 -0700
Subject: dm-raid: fix a race condition in request handling

From: Shaohua Li <[email protected]>

commit c4d6a1b8e8ea79c439a4871cba540443c9eb13b9 upstream.

raid_map calls pers->make_request, which missed the suspend check. Fix it with the new md_handle_request API.

Fix: cc27b0c78c79(md: fix deadlock between mddev_suspend() and md_write_start())

---
 drivers/md/dm-raid.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/dm-raid.c +1 -1
@@ -3238,7 +3238,7 @@ static int raid_map(struct dm_target *ti
 	if (unlikely(bio_end_sector(bio) > mddev->array_sectors))
 		return DM_MAPIO_REQUEUE;
 
-	mddev->pers->make_request(mddev, bio);
+	md_handle_request(mddev, bio);
 
 	return DM_MAPIO_SUBMITTED;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/md-raid5-preserve-stripe_on_unplug_list-in-break_stripe_batch_list.patch queue-4.13/dm-raid-fix-a-race-condition-in-request-handling.patch queue-4.13/md-raid5-fix-a-race-condition-in-stripe-batch.patch

author maintainer
#1 lore raw
Quoted 8 lines · On Mon, Oct 02, 2017 at 11:41:39AM +0200, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

dm-raid: fix a race condition in request handling

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
dm-raid-fix-a-race-condition-in-request-handling.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Nope, this broke the build, so if it should go into 4.13-stable, someone needs to provide a working version of this :(

thanks,

greg k-h