Skip to contentSkip to conversation

Patch "SMB3: Fix endian warning" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Oct 2, 2017 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

SMB3: Fix endian warning

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
smb3-fix-endian-warning.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 590d08d3da45e9fed423b08ab38d71886c07abc8 Mon Sep 17 00:00:00 2001

From: Steve French <[email protected]>
Date: Tue, 19 Sep 2017 11:43:47 -0500
Subject: SMB3: Fix endian warning

From: Steve French <[email protected]>

commit 590d08d3da45e9fed423b08ab38d71886c07abc8 upstream.

Multi-dialect negotiate patch had a minor endian error.

---
 fs/cifs/smb2pdu.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
fs/cifs/smb2pdu.c +3 -2
@@ -558,10 +558,11 @@ SMB2_negotiate(const unsigned int xid, s
 			/* ops set to 3.0 by default for default so update */
 			ses->server->ops = &smb21_operations;
 		}
-	} else if (rsp->DialectRevision != ses->server->vals->protocol_id) {
+	} else if (le16_to_cpu(rsp->DialectRevision) !=
+				ses->server->vals->protocol_id) {
 		/* if requested single dialect ensure returned dialect matched */
 		cifs_dbg(VFS, "Illegal 0x%x dialect returned: not requested\n",
-			cpu_to_le16(rsp->DialectRevision));
+			le16_to_cpu(rsp->DialectRevision));
 		return -EIO;
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/cifs-release-cifs-root_cred-after-exit_cifs.patch queue-4.13/smb3-warn-user-if-trying-to-sign-connection-that-authenticated-as-guest.patch queue-4.13/smb3-handle-new-statx-fields.patch queue-4.13/smb3-add-support-for-multidialect-negotiate-smb2.1-and-later.patch queue-4.13/smb3-don-t-ignore-o_sync-o_dsync-and-o_direct-flags.patch queue-4.13/fix-smb3.1.1-guest-authentication-to-samba.patch queue-4.13/cifs-release-auth_key.response-for-reconnect.patch queue-4.13/smb3-fix-endian-warning.patch queue-4.13/smb-validate-negotiate-to-protect-against-downgrade-even-if-signing-off.patch queue-4.13/cifs-check-rsp-for-null-before-dereferencing-in-smb2_open.patch