FAILED: patch "[PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h" failed to apply to 4.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
10859f3855db4c6f10dc7974ff4b3a292f3de8e0Mon Sep 17 00:00:00 2001
From: Kees Cook <[email protected]>
Date: Thu, 7 Sep 2017 16:32:46 -0700
Subject: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h
The 2.26 release of glibc changed how siginfo_t is defined, and the earlier work-around to using the kernel definition are no longer needed. The old way needs to stay around for a while, though.
tools/testing/selftests/seccomp/seccomp_bpf.c +13 -5
@@ -6,10 +6,18 @@*/ #include <sys/types.h> -#include <asm/siginfo.h> -#define __have_siginfo_t 1 -#define __have_sigval_t 1 -#define __have_sigevent_t 1 + +/* +* glibc 2.26 and later have SIGSYS in siginfo_t. Before that, +* we need to use the kernel's siginfo.h file and trick glibc +* into accepting it. +*/ +#if !__GLIBC_PREREQ (2 ,26 ) +# include <asm/siginfo.h> +# define __have_siginfo_t 1 +# define __have_sigval_t 1 +# define __have_sigevent_t 1 +#endif #include <errno.h> #include <linux/filter.h>
@@ -676,7 +684,7 @@ TEST_F_SIGNAL(TRAP, ign, SIGSYS)syscall (__NR_getpid); } -static struct siginfo TRAP_info; +static siginfo_t TRAP_info;static volatile int TRAP_nr;static void TRAP_action (int nr,siginfo_t *info,void *void_context) {
Quoted 9 lines · On 10/02/2017 05:49 AM, [email protected] wrote:
The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
Hi Kees,
Could you please send a patch for 4.4 stable if this fix is applicable
Quoted 51 lines
------------------ original commit in Linus's tree ------------------
Quoted 1 line
Quoted 1 line
From
10859f3855db4c6f10dc7974ff4b3a292f3de8e0Mon Sep 17 00:00:00 2001From: Kees Cook <[email protected]>
Date: Thu, 7 Sep 2017 16:32:46 -0700
Subject: [PATCH] selftests/seccomp: Support glibc 2.26siginfo_t.hThe 2.26 release of glibc changed how
siginfo_tis defined, and the earlier work-around to using the kernel definition are no longer needed. The old way needs to stay around for a while, though.Reported-by Seth Forshee <[email protected]>Cc Andy Lutomirski <[email protected]>Cc Will Drewry <[email protected]>Cc Shuah Khan <[email protected]>Signed-off-by Kees Cook <[email protected]>Tested-by Seth Forshee <[email protected]>Signed-off-by Shuah Khan <[email protected]>tools/testing/selftests/seccomp/seccomp_bpf.c +12
-4@@ -6,10 +6,18 @@*/ #include <sys/types.h> -#include <asm/siginfo.h> -#define __have_siginfo_t 1 -#define __have_sigval_t 1 -#define __have_sigevent_t 1 + +/* +* glibc 2.26 and later have SIGSYS in siginfo_t. Before that, +* we need to use the kernel's siginfo.h file and trick glibc +* into accepting it. +*/ +#if !__GLIBC_PREREQ (2 ,26 ) +# include <asm/siginfo.h> +# define __have_siginfo_t 1 +# define __have_sigval_t 1 +# define __have_sigevent_t 1 +#endif #include <errno.h> #include <linux/filter.h>
tools/testing/selftests/seccomp/seccomp_bpf.c TEST_F_SIGNAL(TRAP, ign, SIGSYS) · line 690
Quoted 8 lines
tools/testing/selftests/seccomp/seccomp_bpf.c +1
-1@@ -676,7 +684,7 @@ TEST_F_SIGNAL(TRAP, ign, SIGSYS)syscall (__NR_getpid); } -static struct siginfo TRAP_info; +static siginfo_t TRAP_info;static volatile int TRAP_nr;static void TRAP_action (int nr,siginfo_t *info,void *void_context) {
thanks,
-- Shuah