Skip to contentSkip to conversation

Patch "timer/sysclt: Restrict timer migration sysctl values to 0 and 1" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

timer/sysclt: Restrict timer migration sysctl values to 0 and 1

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
timer-sysclt-restrict-timer-migration-sysctl-values-to-0-and-1.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b94bf594cf8ed67cdd0439e70fa939783471597a Mon Sep 17 00:00:00 2001

From: Myungho Jung <[email protected]>
Date: Wed, 19 Apr 2017 15:24:50 -0700
Subject: timer/sysclt: Restrict timer migration sysctl values to 0 and 1

From: Myungho Jung <[email protected]>

commit b94bf594cf8ed67cdd0439e70fa939783471597a upstream.

timer_migration sysctl acts as a boolean switch, so the allowed values should be restricted to 0 and 1.

Add the necessary extra fields to the sysctl table entry to enforce that.

[ tglx: Rewrote changelog ]

---
 kernel/sysctl.c     |    2 ++
 kernel/time/timer.c |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
kernel/sysctl.c +2 -0
@@ -1159,6 +1159,8 @@ static struct ctl_table kern_table[] = {
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
 		.proc_handler	= timer_migration_handler,
+		.extra1		= &zero,
+		.extra2		= &one,
 	},
 #endif
 #ifdef CONFIG_BPF_SYSCALL
kernel/time/timer.c +1 -1
@@ -127,7 +127,7 @@ int timer_migration_handler(struct ctl_t
 	int ret;
 
 	mutex_lock(&mutex);
-	ret = proc_dointvec(table, write, buffer, lenp, ppos);
+	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
 	if (!ret && write)
 		timers_update_migration(false);
 	mutex_unlock(&mutex);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/timer-sysclt-restrict-timer-migration-sysctl-values-to-0-and-1.patch