drm: fix typo in drm_gem_get_pages() comment
Subsystems (3)
PATCH 1/1 drm: fix typo in drm_gem_get_pages() comment
I spent an embarrassingly long time looking for drm_gem_init_object() before I realized I was actually looking for drm_gem_object_init(). Fix the typo to keep other poor developers from suffering the same fate.
--- drivers/gpu/drm/drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_gem.c +1 -1
@@ -543,7 +543,7 @@ int drm_gem_create_mmap_offset(struct drm_gem_object *obj)* Note that you are not allowed to change gfp-zones during runtime. That is, * shmem_read_mapping_page_gfp() must be called with the same gfp_zone(gfp) as * set during initialization. If you have special zone constraints, set them -* after drm_gem_init_object() via mapping_set_gfp_mask(). shmem-core takes care +* after drm_gem_object_init() via mapping_set_gfp_mask(). shmem-core takes care * to keep pages in the required zone during swap-in. */ struct page **drm_gem_get_pages (struct drm_gem_object *obj)
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Jordan Crouse
I spent an embarrassingly long time looking for
drm_gem_init_object()before I realized I was actually looking fordrm_gem_object_init(). Fix the typo to keep other poor developers from suffering the same fate.Signed-off-by Jordan Crouse <[email protected]>
Yeah would be nice if sphinx would complain a bit louder about symlinks it can't find ...
Thanks for fixing this, applied.
-Daniel
Quoted 24 lines
--- drivers/gpu/drm/drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_gem.c +1
-1@@ -543,7 +543,7 @@ int drm_gem_create_mmap_offset(struct drm_gem_object *obj)* Note that you are not allowed to change gfp-zones during runtime. That is, * shmem_read_mapping_page_gfp() must be called with the same gfp_zone(gfp) as * set during initialization. If you have special zone constraints, set them -* after drm_gem_init_object() via mapping_set_gfp_mask(). shmem-core takes care +* after drm_gem_object_init() via mapping_set_gfp_mask(). shmem-core takes care * to keep pages in the required zone during swap-in. */ struct page **drm_gem_get_pages (struct drm_gem_object *obj)Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 10 lines · Daniel Vetter
Quoted 6 lines · Jordan Crouse
I spent an embarrassingly long time looking for
drm_gem_init_object()before I realized I was actually looking fordrm_gem_object_init(). Fix the typo to keep other poor developers from suffering the same fate.Signed-off-by Jordan Crouse <[email protected]>Yeah would be nice if sphinx would complain a bit louder about symlinks it can't find ...
But if it did, we'd never have been able to do a gradual conversion to it!
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel