drm/amdgpu: refine code delete duplicated error handling
Subsystems (2)
PATCH 1/1 drm/amdgpu: refine code delete duplicated error handling
in function amdgpu_ucode_init_bo, when failed, it will set load_type to AMDGPU_FW_LOAD_DIRECT.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -2
@@ -1679,8 +1679,8 @@ static int amdgpu_init(struct amdgpu_device *adev) }mutex_lock (&adev->firmware.mutex); -if (amdgpu_ucode_init_bo (adev)) - adev->firmware.load_type =AMDGPU_FW_LOAD_DIRECT ; +if (adev->firmware.load_type !=AMDGPU_FW_LOAD_DIRECT ) +amdgpu_ucode_init_bo (adev);mutex_unlock (&adev->firmware.mutex);for (i =0 ; i < adev->num_ip_blocks; i++) {
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Reviewed-by Alex DeucherQuoted 8 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Rex Zhu
Sent: Monday, October 09, 2017 2:02 AM
To: [email protected]
Cc: Zhu, Rex
Subject: [PATCH] drm/amdgpu: refine code delete duplicated error handling
Quoted 5 lines
in function
amdgpu_ucode_init_bo, when failed, it will setload_typetoAMDGPU_FW_LOAD_DIRECT.Change-Id Id671b168425dc46331aaf4bd2b734e88b9bfaf3cSigned-off-by Rex Zhu <[email protected]>
Quoted 24 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-2@@ -1679,8 +1679,8 @@ static int amdgpu_init(struct amdgpu_device *adev) }mutex_lock (&adev->firmware.mutex); -if (amdgpu_ucode_init_bo (adev)) - adev->firmware.load_type =AMDGPU_FW_LOAD_DIRECT ; +if (adev->firmware.load_type !=AMDGPU_FW_LOAD_DIRECT ) +amdgpu_ucode_init_bo (adev);mutex_unlock (&adev->firmware.mutex);for (i = 0; i <
adev->num_ip_blocks; i++) {
--
1.9.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx