Patch "l2tp: fix l2tp_eth module loading" has been added to the 4.13-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
l2tp: fix l2tp_eth module loading
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
l2tp-fix-l2tp_eth-module-loading.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Oct 9 09:32:35 CEST 2017
From: Guillaume Nault <[email protected]>
Date: Thu, 28 Sep 2017 15:44:38 +0200
Subject: l2tp: fix l2tp_eth module loading
From: Guillaume Nault <[email protected]>
[ Upstream commit 9f775ead5e570e7e19015b9e4e2f3dd6e71a5935 ]
The l2tp_eth module crashes if its netlink callbacks are run when the pernet data aren't initialised.
We should normally register_pernet_device() before the genl callbacks. However, the pernet data only maintain a list of l2tpeth interfaces, and this list is never used. So let's just drop pernet handling instead.
--- net/l2tp/l2tp_eth.c | 51 ++------------------------------------------------- 1 file changed, 2 insertions(+), 49 deletions(-)
net/l2tp/l2tp_eth.c +2 -49
@@ -44,7 +44,6 @@ struct l2tp_eth {struct net_device *dev;struct sock *tunnel_sock;struct l2tp_session *session; -struct list_head list;atomic_long_t tx_bytes;atomic_long_t tx_packets;atomic_long_t tx_dropped;
@@ -58,17 +57,6 @@ struct l2tp_eth_sess {struct net_device *dev; }; -/* per-net private data for this module */ -static unsigned int l2tp_eth_net_id; -struct l2tp_eth_net { -struct list_head l2tp_eth_dev_list; -spinlock_t l2tp_eth_lock; -}; - -static inline struct l2tp_eth_net *l2tp_eth_pernet (struct net *net) -{ -return net_generic (net, l2tp_eth_net_id); -}static int l2tp_eth_dev_init (struct net_device *dev) {
@@ -84,12 +72,6 @@ static int l2tp_eth_dev_init(struct net_static void l2tp_eth_dev_uninit (struct net_device *dev) { -struct l2tp_eth *priv =netdev_priv (dev); -struct l2tp_eth_net *pn =l2tp_eth_pernet (dev_net (dev)); - -spin_lock (&pn->l2tp_eth_lock); -list_del_init (&priv->list); -spin_unlock (&pn->l2tp_eth_lock);dev_put (dev); }
@@ -272,7 +254,6 @@ static int l2tp_eth_create(struct net *nstruct l2tp_eth *priv;struct l2tp_eth_sess *spriv;int rc; -struct l2tp_eth_net *pn; tunnel =l2tp_tunnel_find (net, tunnel_id);if (!tunnel) {
@@ -310,7 +291,6 @@ static int l2tp_eth_create(struct net *n priv =netdev_priv (dev); priv->dev = dev; priv->session = session; -INIT_LIST_HEAD (&priv->list); priv->tunnel_sock = tunnel->sock; session->recv_skb = l2tp_eth_dev_recv;
@@ -331,10 +311,6 @@ static int l2tp_eth_create(struct net *nstrlcpy (session->ifname, dev->name,IFNAMSIZ );dev_hold (dev); - pn =l2tp_eth_pernet (dev_net (dev)); -spin_lock (&pn->l2tp_eth_lock); -list_add (&priv->list, &pn->l2tp_eth_dev_list); -spin_unlock (&pn->l2tp_eth_lock);return 0 ;
@@ -347,22 +323,6 @@ out:return rc; } -static __net_init int l2tp_eth_init_net (struct net *net) -{ -struct l2tp_eth_net *pn =net_generic (net, l2tp_eth_net_id); - -INIT_LIST_HEAD (&pn->l2tp_eth_dev_list); -spin_lock_init (&pn->l2tp_eth_lock); - -return 0 ; -} - -static struct pernet_operations l2tp_eth_net_ops = { - .init = l2tp_eth_init_net, - .id = &l2tp_eth_net_id, - .size =sizeof (struct l2tp_eth_net ), -}; -static const struct l2tp_nl_cmd_ops l2tp_eth_nl_cmd_ops = { .session_create = l2tp_eth_create,
@@ -376,25 +336,18 @@ static int __init l2tp_eth_init(void) err =l2tp_nl_register_ops (L2TP_PWTYPE_ETH , &l2tp_eth_nl_cmd_ops);if (err) - goto out; - - err =register_pernet_device (&l2tp_eth_net_ops); -if (err) - goto out_unreg; + goto err;pr_info ("L2TP ethernet pseudowire support (L2TPv3)\n" );return 0 ; -out_unreg: -l2tp_nl_unregister_ops (L2TP_PWTYPE_ETH ); -out: +err:return err; } static void __exit l2tp_eth_exit(void) { -unregister_pernet_device (&l2tp_eth_net_ops);l2tp_nl_unregister_ops (L2TP_PWTYPE_ETH ); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/l2tp-fix-race-condition-in-l2tp_tunnel_delete.patch queue-4.13/l2tp-fix-l2tp_eth-module-loading.patch