Patch "usb: gadget: udc: atmel: set vbus irqflags explicitly" has been added to the 4.4-stable tree
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: atmel: set vbus irqflags explicitly
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-gadget-udc-atmel-set-vbus-irqflags-explicitly.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
6baeda120d90aa637b08f7604de104ab00ce9126Mon Sep 17 00:00:00 2001
From: Nicolas Ferre <[email protected]>
Date: Thu, 31 Aug 2017 14:51:40 +0200
Subject: usb: gadget: udc: atmel: set vbus irqflags explicitly
From: Nicolas Ferre <[email protected]>
commit 6baeda120d90aa637b08f7604de104ab00ce9126 upstream.
The driver triggers actions on both edges of the vbus signal.
The former PIO controller was triggering IRQs on both falling and rising edges by default. Newer PIO controller don't, so it's better to set it explicitly to IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING.
Without this patch we may trigger the connection with host but only on some bouncing signal conditions and thus lose connecting events.
--- drivers/usb/gadget/udc/atmel_usba_udc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/gadget/udc/atmel_usba_udc.c +3 -1
@@ -28,6 +28,8 @@#include <asm/gpio.h> #include "atmel_usba_udc.h" +#define USBA_VBUS_IRQFLAGS (IRQF_ONESHOT \ + | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING)#ifdef CONFIG_USB_GADGET_DEBUG_FS #include <linux/debugfs.h>
@@ -2185,7 +2187,7 @@ static int usba_udc_probe(struct platfor IRQ_NOAUTOEN); ret =devm_request_threaded_irq (&pdev->dev,gpio_to_irq (udc->vbus_pin),NULL , - usba_vbus_irq_thread,IRQF_ONESHOT , + usba_vbus_irq_thread,USBA_VBUS_IRQFLAGS ,"atmel_usba_udc" , udc);if (ret) { udc->vbus_pin = -ENODEV ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/usb-gadget-udc-atmel-set-vbus-irqflags-explicitly.patch