Skip to contentSkip to conversation

Patch "net: rtnetlink: fix info leak in RTM_GETSTATS call" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Oct 10, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: rtnetlink: fix info leak in RTM_GETSTATS call

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-rtnetlink-fix-info-leak-in-rtm_getstats-call.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Tue Oct 10 16:09:22 CEST 2017

From: Nikolay Aleksandrov <[email protected]>
Date: Tue, 3 Oct 2017 13:20:48 +0300
Subject: net: rtnetlink: fix info leak in RTM_GETSTATS call

From: Nikolay Aleksandrov <[email protected]>

[ Upstream commit ce024f42c2e28b6bce4ecc1e891b42f57f753892 ]

When RTM_GETSTATS was added the fields of its header struct were not all initialized when returning the result thus leaking 4 bytes of information to user-space per rtnl_fill_statsinfo call, so initialize them now. Thanks to Alexander Potapenko for the detailed report and bisection.

Fixes 10c9ead9f3c6 ("rtnetlink: add new RTM_GETSTATS message to dump link stats")
---
 net/core/rtnetlink.c |    3 +++
 1 file changed, 3 insertions(+)
net/core/rtnetlink.c +3 -0
@@ -3758,6 +3758,9 @@ static int rtnl_fill_statsinfo(struct sk
 		return -EMSGSIZE;
 
 	ifsm = nlmsg_data(nlh);
+	ifsm->family = PF_UNSPEC;
+	ifsm->pad1 = 0;
+	ifsm->pad2 = 0;
 	ifsm->ifindex = dev->ifindex;
 	ifsm->filter_mask = filter_mask;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/net-rtnetlink-fix-info-leak-in-rtm_getstats-call.patch