Skip to contentSkip to conversation

drm/amd/display/dc: drop dm_delay_in_microseconds

PATCH In review Alex Deucher 2 participants 3 messages Oct 11, 2017 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amd/display/dc: drop dm_delay_in_microseconds

Use udelay directly.

---
 drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 4 ++--
 drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c      | 4 ++--
 drivers/gpu/drm/amd/display/dc/dm_services.h       | 3 ---
 3 files changed, 4 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c +2 -2
index 616431e..5f815ca 100644
@@ -127,7 +127,7 @@ static bool edp_receiver_ready_T9(struct dc_link *link)
 			break;
 		if (result != DC_OK)
 			break;
-		dm_delay_in_microseconds(link->ctx, 100); //MAx T9
+		udelay(100); //MAx T9
 	} while (++tries < 50);
 	return result;
 }
@@ -271,7 +271,7 @@ void dp_retrain_link_dp_test(struct dc_link *link,
 			pipes[i].stream->sink->link != NULL &&
 			pipes[i].stream_res.stream_enc != NULL &&
 			pipes[i].stream->sink->link == link) {
-			dm_delay_in_microseconds(link->ctx, 100);
+			udelay(100);
 
 			pipes[i].stream_res.stream_enc->funcs->dp_blank(
 					pipes[i].stream_res.stream_enc);
drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c +2 -2
index f9873ca..3691c74 100644
@@ -137,7 +137,7 @@ static void dce_dmcu_set_psr_enable(struct dmcu *dmcu, bool enable, bool wait)
 					if (psr_state == 0)
 						break;
 				}
-				dm_delay_in_microseconds(dmcu->ctx, 10);
+				udelay(10);
 		}
 	}
 }
@@ -378,7 +378,7 @@ static void dcn10_dmcu_set_psr_enable(struct dmcu *dmcu, bool enable, bool wait)
 			if (psr_state == 0)
 				break;
 		}
-		dm_delay_in_microseconds(dmcu->ctx, 500);
+		udelay(500);
 	}
 
 	/* assert if max retry hit */
drivers/gpu/drm/amd/display/dc/dm_services.h +0 -3
index 8166027..a11991c 100644
@@ -404,9 +404,6 @@ bool dm_read_persistent_data(struct dc_context *ctx,
 		unsigned int size,
 		struct persistent_data_flag *flag);
 
-void dm_delay_in_microseconds
-	(struct dc_context *ctx, unsigned int microSeconds);
-
 bool dm_query_extended_brightness_caps
 	(struct dc_context *ctx, enum dm_acpi_display_type display,
 			struct dm_acpi_atif_backlight_caps *pCaps);
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1507740690-3377-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw

PATCH 2/2 drm/amd/display: drop unused dm_delay_in_microseconds

No longer used.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c +0 -7
index 2c3cd51..43bf829 100644
@@ -59,13 +59,6 @@ bool dm_read_persistent_data(struct dc_context *ctx,
 	return false;
 }
 
-void dm_delay_in_microseconds(struct dc_context *ctx,
-					unsigned int microSeconds)
-{
-	/*TODO implement*/
-	return;
-}
-
 /**** power component interfaces ****/
 
 bool dm_pp_pre_dce_clock_change(
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1507740690-3377-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#4 lore raw

Re: [PATCH 2/2] drm/amd/display: drop unused dm_delay_in_microseconds

Quoted 3 lines · Alex Deucher

No longer used.

Series is

Harry

Quoted 13 lines
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c +0 -0
index 2c3cd51..43bf829 100644
@@ -59,13 +59,6 @@ bool dm_read_persistent_data(struct dc_context *ctx,
 	return false;
 }
 

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c bool dm_read_persistent_data(struct dc_context *ctx, · line 64

Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c +0 -7
-void dm_delay_in_microseconds(struct dc_context *ctx,
-					unsigned int microSeconds)
-{
-	/*TODO implement*/
-	return;
-}
-
 /**** power component interfaces ****/
 
 bool dm_pp_pre_dce_clock_change(

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx