hfs/hfsplus: Clean up unused variables in bnode.c
Subsystems (3)
PATCH 1/1 hfs/hfsplus: Clean up unused variables in bnode.c
Delete variables 'tree' and 'sb', which are set but never used.
Signed-off-by Christos Gkekas <[email protected]>
--- fs/hfs/bnode.c | 4 ---- fs/hfsplus/bnode.c | 4 ---- 2 files changed, 8 deletions(-)
fs/hfs/bnode.c +0 -4
@@ -97,13 +97,11 @@ void hfs_bnode_clear(struct hfs_bnode *node, int off, int len)void hfs_bnode_copy (struct hfs_bnode *dst_node,int dst,struct hfs_bnode *src_node,int src,int len) { -struct hfs_btree *tree;struct page *src_page, *dst_page;hfs_dbg (BNODE_MOD ,"copybytes: %u,%u,%u\n" , dst, src, len);if (!len)return ; - tree = src_node->tree; src += src_node->page_offset; dst += dst_node->page_offset; src_page = src_node->page[0 ];
@@ -236,7 +234,6 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)static struct hfs_bnode *__hfs_bnode_create (struct hfs_btree *tree,u32 cnid) { -struct super_block *sb;struct hfs_bnode *node, *node2;struct address_space *mapping;struct page *page;
@@ -248,7 +245,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)return NULL ; } - sb = tree->inode->i_sb; size =sizeof (struct hfs_bnode ) + tree->pages_per_bnode *sizeof (struct page *); node =kzalloc (size,GFP_KERNEL );
fs/hfsplus/bnode.c +0 -4
@@ -126,14 +126,12 @@ void hfs_bnode_clear(struct hfs_bnode *node, int off, int len)void hfs_bnode_copy (struct hfs_bnode *dst_node,int dst,struct hfs_bnode *src_node,int src,int len) { -struct hfs_btree *tree;struct page **src_page, **dst_page;int l;hfs_dbg (BNODE_MOD ,"copybytes: %u,%u,%u\n" , dst, src, len);if (!len)return ; - tree = src_node->tree; src += src_node->page_offset; dst += dst_node->page_offset; src_page = src_node->page + (src >>PAGE_SHIFT );
@@ -400,7 +398,6 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)static struct hfs_bnode *__hfs_bnode_create (struct hfs_btree *tree,u32 cnid) { -struct super_block *sb;struct hfs_bnode *node, *node2;struct address_space *mapping;struct page *page;
@@ -413,7 +410,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)return NULL ; } - sb = tree->inode->i_sb; size =sizeof (struct hfs_bnode ) + tree->pages_per_bnode *sizeof (struct page *); node =kzalloc (size,GFP_KERNEL );
Signature · 1 line
2.7.4
Quoted 3 lines · Christos Gkekas
Delete variables 'tree' and 'sb', which are set but never used.
Signed-off-by Christos Gkekas <[email protected]>
Looks good. If it helps you can add:
Reviewed-by Ernesto A. Fernández <[email protected]>
Quoted 77 lines
--- fs/hfs/bnode.c | 4 ---- fs/hfsplus/bnode.c | 4 ---- 2 files changed, 8 deletions(-)fs/hfs/bnode.c +0
-4@@ -97,13 +97,11 @@ void hfs_bnode_clear(struct hfs_bnode *node, int off, int len)void hfs_bnode_copy (struct hfs_bnode *dst_node,int dst,struct hfs_bnode *src_node,int src,int len) { -struct hfs_btree *tree;struct page *src_page, *dst_page;hfs_dbg (BNODE_MOD ,"copybytes: %u,%u,%u\n" , dst, src, len);if (!len)return ; - tree = src_node->tree; src += src_node->page_offset; dst += dst_node->page_offset; src_page = src_node->page[0 ];@@ -236,7 +234,6 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)static struct hfs_bnode *__hfs_bnode_create (struct hfs_btree *tree,u32 cnid) { -struct super_block *sb;struct hfs_bnode *node, *node2;struct address_space *mapping;struct page *page;@@ -248,7 +245,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)return NULL ; } - sb = tree->inode->i_sb; size =sizeof (struct hfs_bnode ) + tree->pages_per_bnode *sizeof (struct page *); node =kzalloc (size,GFP_KERNEL );fs/hfsplus/bnode.c +0
-4@@ -126,14 +126,12 @@ void hfs_bnode_clear(struct hfs_bnode *node, int off, int len)void hfs_bnode_copy (struct hfs_bnode *dst_node,int dst,struct hfs_bnode *src_node,int src,int len) { -struct hfs_btree *tree;struct page **src_page, **dst_page;int l;hfs_dbg (BNODE_MOD ,"copybytes: %u,%u,%u\n" , dst, src, len);if (!len)return ; - tree = src_node->tree; src += src_node->page_offset; dst += dst_node->page_offset; src_page = src_node->page + (src >>PAGE_SHIFT );@@ -400,7 +398,6 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)static struct hfs_bnode *__hfs_bnode_create (struct hfs_btree *tree,u32 cnid) { -struct super_block *sb;struct hfs_bnode *node, *node2;struct address_space *mapping;struct page *page;@@ -413,7 +410,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)return NULL ; } - sb = tree->inode->i_sb; size =sizeof (struct hfs_bnode ) + tree->pages_per_bnode *sizeof (struct page *); node =kzalloc (size,GFP_KERNEL );Signature · 1 line
2.7.4