Skip to contentSkip to conversation

dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

PATCH Maninder Singh 2 participants 2 messages May 22, 2015 dmaengine

lore
Share & tools
lore

Maninder Singh

author Reviewed-by Vaneet Narang
#0 lore raw

EP-AA9D1F29B02341529D96C06444D8471D
Hi Vinod

Quoted 5 lines · Maninder Singh
Quoted 1 line

EP-AA9D1F29B02341529D96C06444D8471D

Whats this, please sned patch ina proper format, git format-patch is your friend, use it

This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback.

Quoted 5 lines
Quoted 3 lines

Hi,
Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

patch title doesn't match expectations, use the right subsystem name, and also please explain why yoy are doing this

Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git, But i think editor does some malfunctioning.

Quoted 5 lines
Quoted 5 lines
---
 drivers/dma/pl330.c |    4 +++-

---cut---

Quoted 8 lines
Quoted 2 lines

Thanks
Maninder Singh

Nice signature!

Signature · 3 lines
~Vinod

From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001

From: Maninder Singh <[email protected]>
Date: Mon, 18 May 2015 17:53:11 +0530
Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch

Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning:
warn: variable dereferenced before check 'pch'

So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch.

---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/dma/pl330.c +3 -1
index a7d9d30..7e27144 100644
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
Signature · 6 lines
1.7.1

Thanks
Maninder
............
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºʇڙë,j­¢f£¢·hš�ï�êÿ‘êçz_è®(­éšŽŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨è­Ú&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿÃÿ¶ìÿ¢¸?–I¥
#1 lore raw
Quoted 12 lines · Maninder Singh

EP-AA9D1F29B02341529D96C06444D8471D
Hi Vinod

Quoted 5 lines · Maninder Singh
Quoted 1 line

EP-AA9D1F29B02341529D96C06444D8471D

Whats this, please sned patch ina proper format, git format-patch is your friend, use it

This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback.

Quoted 1 line
Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Hi,
Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

patch title doesn't match expectations, use the right subsystem name, and also please explain why yoy are doing this

Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git, But i think editor does some malfunctioning.

Hint here is NOT to use editor to send patches, git send-email is your friend. Also do consider wrapping your lines appropriately

Below looks much better, but the mailer has screwed it up and am unable to apply, so please resend with git send-mail.

Thanks

Signature · 1 line
~Vinod 
Quoted 56 lines
Quoted 6 lines
Quoted 6 lines
---
 drivers/dma/pl330.c |    4 +++-

---cut---

Quoted 6 lines
Quoted 2 lines

Thanks
Maninder Singh

Nice signature!

Signature · 1 line
~Vinod

From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001
From: Maninder Singh <[email protected]>
Date: Mon, 18 May 2015 17:53:11 +0530
Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch

Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning:
warn: variable dereferenced before check 'pch'

So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch.

---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/dma/pl330.c +3 -1
index a7d9d30..7e27144 100644
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
Signature · 5 lines
1.7.1

Thanks
Maninder
............