Skip to contentSkip to conversation

net: fec_mxc: Change "error frame" message to debug level

PATCH New Fabio Estevam 1 participant 3 messages Oct 15, 2017 – Oct 31, 2017 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: fec_mxc: Change "error frame" message to debug level

From: Fabio Estevam <[email protected]>

As reported by Jonathan Gray:

"After the recent changes to add SimpleNetworkProtocol to efi_loader when booting off mmc via an efi payload that doesn't use SimpleNetworkProtocol U-Boot's fec_mxc driver will now display various "error frame" messages.
....
MMC Device 1 not found
MMC Device 2 not found
MMC Device 3 not found
Scanning disks on sata...
Found 6 disks
reading efi/boot/bootarm.efi
67372 bytes read in 32 ms (2 MiB/s)
## Starting EFI application at 12000000 ...

Quoted 1 line
Quoted 1 line

OpenBSD/armv7 BOOTARM 1.0

error frame: 0x8f57ec40 0x00003d74
error frame: 0x8f57ec40 0x00007079
error frame: 0x8f57ec40 0x00006964
error frame: 0x8f57ec40 0x00006f6f
error frame: 0x8f57ec40 0x0000726f
error frame: 0x8f57ec40 0x00002074
error frame: 0x8f57ec40 0x00006f6f"

Heinrich Schuchardt explains:

"A receive FIFO overrun can be expected if network packages are not processed.
With the network patches we check if a package is available quite often."

Move the "error frame" messages to debug level so that a clean output log can be seen.

---
 drivers/net/fec_mxc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/fec_mxc.c +1 -1
index f16b299..433e19f 100644
@@ -882,7 +882,7 @@ static int fec_recv(struct eth_device *dev)
 			len = frame_length;
 		} else {
 			if (bd_status & FEC_RBD_ERR)
-				printf("error frame: 0x%08x 0x%08x\n",
+				debug("error frame: 0x%08x 0x%08x\n",
 				       addr, bd_status);
 		}
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 net: fec_mxc: Change "error frame" message to debug level

Hi Joe,

Quoted 32 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

As reported by Jonathan Gray:

"After the recent changes to add SimpleNetworkProtocol to efi_loader when booting off mmc via an efi payload that doesn't use SimpleNetworkProtocol U-Boot's fec_mxc driver will now display various "error frame" messages.
....
MMC Device 1 not found
MMC Device 2 not found
MMC Device 3 not found
Scanning disks on sata...
Found 6 disks
reading efi/boot/bootarm.efi
67372 bytes read in 32 ms (2 MiB/s)
## Starting EFI application at 12000000 ...

Quoted 1 line
Quoted 1 line

OpenBSD/armv7 BOOTARM 1.0

error frame: 0x8f57ec40 0x00003d74
error frame: 0x8f57ec40 0x00007079
error frame: 0x8f57ec40 0x00006964
error frame: 0x8f57ec40 0x00006f6f
error frame: 0x8f57ec40 0x0000726f
error frame: 0x8f57ec40 0x00002074
error frame: 0x8f57ec40 0x00006f6f"

Heinrich Schuchardt explains:

"A receive FIFO overrun can be expected if network packages are not processed.
With the network patches we check if a package is available quite often."

Quoted 6 lines

Move the "error frame" messages to debug level so that a clean output log can be seen.

Do you think this one can be applied for 2017.11?

Thanks