Skip to contentSkip to conversation

Patch "USB: serial: console: fix use-after-free after failed setup" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Oct 15, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: serial: console: fix use-after-free after failed setup

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-console-fix-use-after-free-after-failed-setup.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 299d7572e46f98534033a9e65973f13ad1ce9047 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Wed, 4 Oct 2017 11:01:13 +0200
Subject: USB: serial: console: fix use-after-free after failed setup

From: Johan Hovold <[email protected]>

commit 299d7572e46f98534033a9e65973f13ad1ce9047 upstream.

Make sure to reset the USB-console port pointer when console setup fails in order to avoid having the struct usb_serial be prematurely freed by the console code when the device is later disconnected.

Fixes 73e487fdb75f ("[PATCH] USB console: fix disconnection issues")
---
 drivers/usb/serial/console.c |    1 +
 1 file changed, 1 insertion(+)
drivers/usb/serial/console.c +1 -0
@@ -186,6 +186,7 @@ static int usb_console_setup(struct cons
 	tty_kref_put(tty);
  reset_open_count:
 	port->port.count = 0;
+	info->port = NULL;
 	usb_autopm_put_interface(serial->interface);
  error_get_interface:
 	usb_serial_put(serial);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/alsa-caiaq-fix-stray-urb-at-probe-error-path.patch queue-4.9/usb-serial-option-add-support-for-tp-link-lte-module.patch queue-4.9/usb-serial-cp210x-add-support-for-elv-tfd500.patch queue-4.9/usb-serial-qcserial-add-dell-dw5818-dw5819.patch queue-4.9/usb-serial-console-fix-use-after-free-after-failed-setup.patch queue-4.9/usb-serial-ftdi_sio-add-id-for-cypress-wiced-dev-board.patch