Skip to contentSkip to conversation

Patch "ALSA: seq: Fix missing NULL check at remove_events ioctl" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Oct 16, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: seq: Fix missing NULL check at remove_events ioctl

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 030e2c78d3a91dd0d27fef37e91950dde333eba1 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Tue, 12 Jan 2016 12:38:02 +0100
Subject: ALSA: seq: Fix missing NULL check at remove_events ioctl

From: Takashi Iwai <[email protected]>

commit 030e2c78d3a91dd0d27fef37e91950dde333eba1 upstream.

snd_seq_ioctl_remove_events() calls snd_seq_fifo_clear() unconditionally even if there is no FIFO assigned, and this leads to an Oops due to NULL dereference. The fix is just to add a proper NULL check.

---
 sound/core/seq/seq_clientmgr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/seq/seq_clientmgr.c +1 -1
@@ -1970,7 +1970,7 @@ static int snd_seq_ioctl_remove_events(s
 		 * No restrictions so for a user client we can clear
 		 * the whole fifo
 		 */
-		if (client->type == USER_CLIENT)
+		if (client->type == USER_CLIENT && client->data.user.fifo)
 			snd_seq_fifo_clear(client->data.user.fifo);
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/alsa-caiaq-fix-stray-urb-at-probe-error-path.patch queue-3.18/alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch queue-3.18/alsa-seq-fix-copy_from_user-call-inside-lock.patch queue-3.18/alsa-seq-fix-use-after-free-at-creating-a-port.patch queue-3.18/alsa-usb-audio-kill-stray-urb-at-exiting.patch