selftests: remove obsolete kconfig fragment for cpu-hotplug
PATCH 1/1 selftests: remove obsolete kconfig fragment for cpu-hotplug
From: Lei Yang <[email protected]>
Kconfig CONFIG_CPU_NOTIFIER_ERROR_INJECT has been removed since kernel 4.10 check commit:
commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
Author: Thomas Gleixner <[email protected]>
Date: Wed Dec 21 20:19:53 2016 +0100
cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions
hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(),
register_hotcpu_notifier(), register_cpu_notifier(),
__register_hotcpu_notifier(), __register_cpu_notifier(),
unregister_hotcpu_notifier(), unregister_cpu_notifier(),
__unregister_hotcpu_notifier(), __unregister_cpu_notifier()
<snip>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)
tools/testing/selftests/cpu-hotplug/config +0 -1
@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
Signature · 1 line
1.9.1
Quoted 28 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0
tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
Yes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Thomas/Greg,
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
thanks,
-- Shuah
Quoted 36 lines · Shuah Khan
Quoted 28 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mYes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Quoted 4 lines
Thomas/Greg,
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
Can you check the kernel version on which you are running and do it runtime conditionally?
Thanks,
tglx
Quoted 37 lines · Thomas Gleixner
Quoted 36 lines · Shuah Khan
Quoted 28 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mYes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Quoted 8 lines
Quoted 4 lines
Thomas/Greg,
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
Can you check the kernel version on which you are running and do it runtime conditionally?
I have been avoiding adding kernel version checks to tests. Maybe this is one exception since the functionality is obsoleted.
In any case, just removing the config isn't the complete solution. I will have to think about this some.
thanks,
-- Shuah
Quoted 39 lines · Shuah Khan
Quoted 38 lines · Thomas Gleixner
Quoted 37 lines · Shuah Khan
Quoted 28 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mYes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Thomas/Greg,
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
Can you check the kernel version on which you are running and do it runtime conditionally?
I have been avoiding adding kernel version checks to tests. Maybe this is one exception since the functionality is obsoleted.
I think the baseline is that we only assure kselftest works on the release it belongs to, for example, removing this config for the version above 4.10, keep it in old release. but looks it doesn't work like this way.
I think We can't assure latest kselftest works still well on a very older releases
yes, for some features it's common for each release. but we have some features that are only available in newer
release. even for the common features, it's difficult to make sure it still works well for each
release. maintenance is a big effort if we use something like version check. you never know what changes will make for general feature in the future release although it's common right now.
Lei
Quoted 10 lines
In any case, just removing the config isn't the complete solution. I will have to think about this some.
thanks,
-- Shuah--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Lei,
Quoted 67 lines · On 2 November 2017 at 07:43, lyang0 <[email protected]> wrote:
Quoted 50 lines · Shuah Khan
Quoted 48 lines · Thomas Gleixner
Quoted 45 lines · Shuah Khan
Quoted 33 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10
check commit:
commit530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
Author: Thomas Gleixner <[email protected]>
Date: Wed Dec 21 20:19:53 2016 +0100cpu/hotplug: Remove obsolete cpu hotplug register/unregister
functionshotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mYes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Thomas/Greg,
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
Quoted 6 lines
Quoted 4 lines
Can you check the kernel version on which you are running and do it runtime
conditionally?I have been avoiding adding kernel version checks to tests. Maybe this is one exception since the functionality is obsoleted.
I think the baseline is that we only assure kselftest works on the release it belongs to, for example, removing this config for the version above 4.10, keep it in old release. but looks it doesn't work like this way.
Quoted 9 lines
I think We can't assure latest kselftest works still well on a very older releases
yes, for some features it's common for each release. but we have some features that are only available in newer
release. even for the common features, it's difficult to make sure it
still works well for each
release. maintenance is a big effort if we use something like version check. you never know what changes will make
for general feature in the future release although it's common right now.
As Greg and several others have reiterated - the tests should be able to check for presence of a feature, run it if it's applicable, and skip if it's not. It really isn't about kernel version check, but writing code and test in such a way that tests can 'degrade gracefully', rather than fail. There are several good examples for the same.
The idea of running newer tests is to gain coverage on older kernels for features still present in them, but tests weren't available at the time of the kernel tagging.
Hope this helps clear the doubt?
Quoted 17 lines
Lei
Quoted 11 lines
In any case, just removing the config isn't the complete solution. I will have to think about this some.
thanks,
-- Shuah--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Best,
Sumit.
Quoted 79 lines · Sumit Semwal
Hello Lei,
Quoted 60 lines · On 2 November 2017 at 07:43, lyang0 <[email protected]> wrote:
Quoted 43 lines · Shuah Khan
Quoted 42 lines · Thomas Gleixner
Quoted 41 lines · Shuah Khan
Quoted 32 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10
check commit:
commit530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
Author: Thomas Gleixner <[email protected]>
Date: Wed Dec 21 20:19:53 2016 +0100cpu/hotplug: Remove obsolete cpu hotplug register/unregister
functionshotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mYes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Thomas/Greg,
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
Can you check the kernel version on which you are running and do it runtime
conditionally?I have been avoiding adding kernel version checks to tests. Maybe this is one exception since the functionality is obsoleted.
I think the baseline is that we only assure kselftest works on the release it belongs to, for example, removing this config for the version above 4.10, keep it in old release. but looks it doesn't work like this way.
Quoted 9 lines
I think We can't assure latest kselftest works still well on a very older releases
yes, for some features it's common for each release. but we have some features that are only available in newer
release. even for the common features, it's difficult to make sure it
still works well for each
release. maintenance is a big effort if we use something like version check. you never know what changes will make
for general feature in the future release although it's common right now.As Greg and several others have reiterated - the tests should be able to check for presence of a feature, run it if it's applicable, and skip if it's not. It really isn't about kernel version check, but writing code and test in such a way that tests can 'degrade gracefully', rather than fail. There are several good examples for the same.
Quoted 3 lines
The idea of running newer tests is to gain coverage on older kernels for features still present in them, but tests weren't available at the time of the kernel tagging.
so we actually don't have version control for kselftest? anytime, we use the latest one
I thought we recommended use the one in 4.12 if we want to test 4.12 kernel, not to use the one in newer version
Quoted 1 line
Hope this helps clear the doubt?
I'm wondering how do you determine this patch apply to which release.
I don't understand "Dropping the config will impact coverage on older releases" , we can just don't apply it to the release older than 4.10. then the coverage doesn't drop.
Lei
Quoted 21 lines
Quoted 15 lines
Lei
Quoted 11 lines
In any case, just removing the config isn't the complete solution. I will have to think about this some.
thanks,
-- Shuah--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.htmlBest,
Sumit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 36 lines · Shuah Khan
Quoted 28 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0tools/testing/selftests/cpu-hotplug/config line 2
Quoted 2 lines
tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mYes. It is removed from the kernel. However, selftests from the latest release do get run routinely on older stable releases. Dropping the config will impact coverage on older releases.
Quoted 4 lines
Thomas/Greg,
Any ideas on what we should do about this. On one hand it is a good idea to remove it, however my concern is coverage on older releases.
If this is a kernel-internal-api/function test, yeah, just remove it, no need to keep it around. The idea of keeping something like this around wouldn't make much sense.
thanks,
greg k-h
Hi Lei,
Quoted 1 line · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
Are you using git send-email to send patches. it is odd to see this extra From: line.
Quoted 15 lines
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>
Please make sure your commit lines are 75 chars or less. Make sure you run chekpatch script on your patches.
I fixed these when I applied the patch. No need to resend this patch. Please make sure to use git send-email and run checkpatch script on your future patches.
Quoted 2 lines
Signed-off-by Lei Yang <[email protected]>
Applied to linux-kselftest next for 4.15-rc1.
tools/testing/selftests/cpu-hotplug/config line 2
Quoted 12 lines
--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
thanks,
-- Shuah
Quoted 12 lines · 在 2017年11月3日,06:14,Shuah Khan <[email protected]> 写道:
Hi Lei,
Quoted 2 lines · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
Are you using git send-email to send patches. it is odd to see this extra From: line.
I use send-email. I'll use checkpatch script before sending, thanks for reminding
Lei
Quoted 42 lines
Quoted 15 lines
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Please make sure your commit lines are 75 chars or less. Make sure you run chekpatch script on your patches.
I fixed these when I applied the patch. No need to resend this patch. Please make sure to use git send-email and run checkpatch script on your future patches.
Quoted 2 lines
Signed-off-by Lei Yang <[email protected]>Applied to linux-kselftest next for 4.15-rc1.
Quoted 11 lines
---
tools/testing/selftests/cpu-hotplug/config| 1 -1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-0@@ -1,2 +1 @@
CONFIG_NOTIFIER_ERROR_INJECTION=y
-CONFIG_CPU_NOTIFIER_ERROR_INJECT=mthanks,
-- Shuah
Quoted 6 lines · Shuah Khan
Hi Lei,
Quoted 1 line · On 10/17/2017 08:10 PM, [email protected] wrote:
From: Lei Yang <[email protected]>
Are you using git send-email to send patches. it is odd to see this extra From: line.
I just find it's caused by my git configuration.
in .gitconfig, comment out below line, then the extra line disappears [sendemail]
#from = [email protected]
Lei
Quoted 38 lines
Quoted 14 lines
KconfigCONFIG_CPU_NOTIFIER_ERROR_INJECThas been removed since kernel 4.10 check commit:commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f Author: Thomas Gleixner <[email protected]> Date: Wed Dec 21 20:19:53 2016 +0100 cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(), register_hotcpu_notifier(), register_cpu_notifier(), __register_hotcpu_notifier(), __register_cpu_notifier(), unregister_hotcpu_notifier(), unregister_cpu_notifier(), __unregister_hotcpu_notifier(), __unregister_cpu_notifier() <snip>Please make sure your commit lines are 75 chars or less. Make sure you run chekpatch script on your patches.
I fixed these when I applied the patch. No need to resend this patch. Please make sure to use git send-email and run checkpatch script on your future patches.
Quoted 1 line
Signed-off-by Lei Yang <[email protected]>Applied to linux-kselftest next for 4.15-rc1.
tools/testing/selftests/cpu-hotplug/config line 2
Quoted 12 lines
--- tools/testing/selftests/cpu-hotplug/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/cpu-hotplug/config +0
-1@@ -1,2 +1 @@ CONFIG_NOTIFIER_ERROR_INJECTION=y -CONFIG_CPU_NOTIFIER_ERROR_INJECT=mthanks,
-- Shuah