Skip to contentSkip to conversation

drm/amd/pp: thermal control not enabled on vega10.

PATCH In review Rex Zhu 2 participants 2 messages Oct 18, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Rex Zhu

author
#0 lore raw

PATCH 1/1 drm/amd/pp: thermal control not enabled on vega10.

regresstion issue.
caused by "f12f9f5e5d455edebc01"
forget to set start_thermal_controller function point.

Change-Id Idcb127daccb96a6b30f8f83e8b1bd65b8f872f55
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c   | 1 +
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -0
index 04666d2..48e1d65 100644
@@ -5108,6 +5108,7 @@ static int vega10_register_thermal_interrupt(struct pp_hwmgr *hwmgr,
 	.avfs_control = vega10_avfs_enable,
 	.notify_cac_buffer_info = vega10_notify_cac_buffer_info,
 	.register_internal_thermal_interrupt = vega10_register_thermal_interrupt,
+	.start_thermal_controller = vega10_start_thermal_controller,
 };
 
 int vega10_hwmgr_init(struct pp_hwmgr *hwmgr)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h +2 -1
index f34ce04..82f10bd 100644
@@ -71,7 +71,8 @@ extern int vega10_fan_ctrl_get_fan_speed_rpm(struct pp_hwmgr *hwmgr,
 extern int vega10_fan_ctrl_stop_smc_fan_control(struct pp_hwmgr *hwmgr);
 extern int vega10_thermal_disable_alert(struct pp_hwmgr *hwmgr);
 extern int vega10_fan_ctrl_start_smc_fan_control(struct pp_hwmgr *hwmgr);
-
+extern int vega10_start_thermal_controller(struct pp_hwmgr *hwmgr,
+				struct PP_TemperatureRange *range);
 extern uint32_t smu7_get_xclk(struct pp_hwmgr *hwmgr);
 
 #endif
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1508308578-25920-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Rex Zhu
Sent: Wednesday, October 18, 2017 2:36 AM
To: [email protected]
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/pp: thermal control not enabled on vega10.

Quoted 6 lines

regresstion issue.
caused by "f12f9f5e5d455edebc01"
forget to set start_thermal_controller function point.

Change-Id Idcb127daccb96a6b30f8f83e8b1bd65b8f872f55
Quoted 37 lines
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c   | 1 +
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -0
index 04666d2..48e1d65 100644
@@ -5108,6 +5108,7 @@ static int vega10_register_thermal_interrupt(struct
 pp_hwmgr *hwmgr,
 	.avfs_control = vega10_avfs_enable,
 	.notify_cac_buffer_info = vega10_notify_cac_buffer_info,
 	.register_internal_thermal_interrupt =
 vega10_register_thermal_interrupt,
+	.start_thermal_controller = vega10_start_thermal_controller,
 };

int vega10_hwmgr_init(struct pp_hwmgr *hwmgr)

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h +2 -1
index f34ce04..82f10bd 100644
@@ -71,7 +71,8 @@ extern int vega10_fan_ctrl_get_fan_speed_rpm(struct
 pp_hwmgr *hwmgr,
 extern int vega10_fan_ctrl_stop_smc_fan_control(struct pp_hwmgr
 *hwmgr);
 extern int vega10_thermal_disable_alert(struct pp_hwmgr *hwmgr);
 extern int vega10_fan_ctrl_start_smc_fan_control(struct pp_hwmgr
 *hwmgr);
-
+extern int vega10_start_thermal_controller(struct pp_hwmgr *hwmgr,
+				struct PP_TemperatureRange *range);

extern uint32_t smu7_get_xclk(struct pp_hwmgr *hwmgr);

Quoted 8 lines

#endif
--
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx