Skip to contentSkip to conversation

Patch "[PATCH] Revert "tty: goldfish: Fix a parameter of a call to free_irq"" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Oct 19, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[PATCH] Revert "tty: goldfish: Fix a parameter of a call to free_irq"

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
revert-tty-goldfish-fix-a-parameter-of-a-call-to-free_irq.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 037c9ebf920ab339593aaf240135c15d66854dc1 Mon Sep 17 00:00:00 2001

From: Greg Kroah-Hartman <[email protected]>
Date: Thu, 19 Oct 2017 15:28:08 +0200
Subject: [PATCH] Revert "tty: goldfish: Fix a parameter of a call to free_irq"

From: Greg Kroah-Hartman <[email protected]>

This reverts commit 0961072120f3e40fe98c2bb49c45549ca3f042dc which is commit 1a5c2d1de7d35f5eb9793266237903348989502b upstream.

Ben writes:
This fixes a bug introduced in 4.6 by commit 465893e18878 "tty:
goldfish: support platform_device with id -1". For earlier kernel versions, it *introduces* a bug.

So let's drop it.

---
 drivers/tty/goldfish.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/goldfish.c +1 -1
@@ -295,7 +295,7 @@ static int goldfish_tty_probe(struct pla
 
 	tty_unregister_device(goldfish_tty_driver, i);
 err_tty_register_device_failed:
-	free_irq(irq, qtty);
+	free_irq(irq, pdev);
 err_request_irq_failed:
 	goldfish_tty_current_line_count--;
 	if (goldfish_tty_current_line_count == 0)

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/net-mlx4_core-fix-vf-overwrite-of-module-param-which-disables-dmfs-on-new-probed-pfs.patch queue-3.18/packet-in-packet_do_bind-test-fanout-with-bind_lock-held.patch queue-3.18/scsi-scsi_dh_emc-return-success-in-clariion_std_inquiry.patch queue-3.18/revert-tty-goldfish-fix-a-parameter-of-a-call-to-free_irq.patch queue-3.18/isdn-i4l-fetch-the-ppp_write-buffer-in-one-shot.patch queue-3.18/x86-mm-disable-preemption-during-cr3-read-write.patch queue-3.18/ext4-avoid-deadlock-when-expanding-inode-size.patch queue-3.18/l2tp-fix-race-condition-in-l2tp_tunnel_delete.patch queue-3.18/vti-fix-use-after-free-in-vti_tunnel_xmit-vti6_tnl_xmit.patch queue-3.18/uapi-fix-linux-mroute6.h-userspace-compilation-errors.patch queue-3.18/irqchip-crossbar-fix-incorrect-type-of-local-variables.patch queue-3.18/watchdog-kempld-fix-gcc-4.3-build.patch queue-3.18/revert-bsg-lib-don-t-free-job-in-bsg_prepare_job.patch queue-3.18/netfilter-nf_ct_expect-change-__nf_ct_expect_check-return-value.patch queue-3.18/ocfs2-dlmglue-prepare-tracking-logic-to-avoid-recursive-cluster-lock.patch queue-3.18/iio-adc-xilinx-fix-error-handling.patch queue-3.18/uapi-fix-linux-rds.h-userspace-compilation-errors.patch queue-3.18/sctp-potential-read-out-of-bounds-in-sctp_ulpevent_type_enabled.patch queue-3.18/drm-dp-mst-save-vcpi-with-payloads.patch queue-3.18/l2tp-avoid-schedule-while-atomic-in-exit_net.patch queue-3.18/crypto-xts-add-ecb-dependency.patch queue-3.18/target-iscsi-fix-unsolicited-data-seq_end_offset-calculation.patch queue-3.18/btrfs-send-fix-failure-to-rename-top-level-inode-due-to-name-collision.patch queue-3.18/bpf-verifier-reject-bpf_alu64-bpf_end.patch queue-3.18/net-set-sk_prot_creator-when-cloning-sockets-to-the-right-proto.patch queue-3.18/packet-hold-bind-lock-when-rebinding-to-fanout-hook.patch queue-3.18/locking-lockdep-add-nest_lock-integrity-test.patch