Skip to contentSkip to conversation

Some changes to fix performance drop on Vega10

PATCH In review Eric Huang 2 participants 6 messages Oct 19, 2017 – Oct 20, 2017 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Eric Huang

author
#0 lore raw

cover Some changes to fix performance drop on Vega10

Eric Huang (2):
drm/amd/powerplay: add one smc message for Vega10 drm/amd/powerplay: fix performance drop on Vega10

 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++++++
 drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h   | 3 ++-
 2 files changed, 8 insertions(+), 1 deletion(-)
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1508440499-19321-1-git-send-email-JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org

author
#2 lore raw

PATCH 1/2 drm/amd/powerplay: add one smc message for Vega10

This is used to fix performance drop caused by updated SMU FW.

---
 drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h +2 -1
index d06ece4..247c973 100644
@@ -131,7 +131,8 @@ typedef uint16_t PPSMC_Result;
 #define PPSMC_MSG_RunAcgInOpenLoop               0x5E
 #define PPSMC_MSG_InitializeAcg                  0x5F
 #define PPSMC_MSG_GetCurrPkgPwr                  0x61
-#define PPSMC_Message_Count                      0x62
+#define PPSMC_MSG_UpdatePkgPwrPidAlpha           0x68
+#define PPSMC_Message_Count                      0x69
 
 
 typedef int PPSMC_Msg;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
author
#3 lore raw

PATCH 2/2 drm/amd/powerplay: fix performance drop on Vega10

In reply to a message not in the archive

Setting package power PID to 1 fixes performance drop caused by updated SMU FW, before DPM is enabled.

---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +6 -0
index 0519338..2daf234 100644
@@ -2879,6 +2879,12 @@ static int vega10_enable_dpm_tasks(struct pp_hwmgr *hwmgr)
 			"DPM is already running right , skipping re-enablement!",
 			return 0);
 
+	tmp_result = smum_send_msg_to_smc_with_parameter(hwmgr,
+			PPSMC_MSG_UpdatePkgPwrPidAlpha, 1);
+	PP_ASSERT_WITH_CODE(!tmp_result,
+			"Failed to set package power PID!",
+			return tmp_result);
+
 	tmp_result = vega10_construct_voltage_tables(hwmgr);
 	PP_ASSERT_WITH_CODE(!tmp_result,
 			"Failed to contruct voltage tables!",
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1508440499-19321-3-git-send-email-JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org

author
#5 lore raw

PATCH 2/2 drm/amd/powerplay: fix performance drop on Vega10 (v2)

Setting package power PID to 1 fixes performance drop caused by updated SMU FW, before DPM is enabled.

---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +9 -0
index 0519338..66a047f 100644
@@ -2879,6 +2879,15 @@ static int vega10_enable_dpm_tasks(struct pp_hwmgr *hwmgr)
 			"DPM is already running right , skipping re-enablement!",
 			return 0);
 
+	if (data->smu_version == 0x001c2c00 ||
+			data->smu_version == 0x001c2d00) {
+		tmp_result = smum_send_msg_to_smc_with_parameter(hwmgr,
+				PPSMC_MSG_UpdatePkgPwrPidAlpha, 1);
+		PP_ASSERT_WITH_CODE(!tmp_result,
+				"Failed to set package power PID!",
+				return tmp_result);
+	}
+
 	tmp_result = vega10_construct_voltage_tables(hwmgr);
 	PP_ASSERT_WITH_CODE(!tmp_result,
 			"Failed to contruct voltage tables!",
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
author
#6 lore raw
In reply to a message not in the archive

Ping.

Quoted 8 lines · Eric Huang

Eric Huang (2):
drm/amd/powerplay: add one smc message for Vega10 drm/amd/powerplay: fix performance drop on Vega10

  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++++++
  drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h   | 3 ++-
  2 files changed, 8 insertions(+), 1 deletion(-)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 18695bbf-f6c0-9d7b-4c16-20b7ba7a0c23-5C7GfCeVMHo@public.gmane.org

Acked-by Alex Deucher
#8 lore raw
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Eric Huang
Sent: Friday, October 20, 2017 2:10 PM
To: [email protected]
Subject: Re: [PATCH 0/2] Some changes to fix performance drop on Vega10

Ping.

Series is:

Quoted 12 lines · Eric Huang
Quoted 8 lines

Eric Huang (2):
drm/amd/powerplay: add one smc message for Vega10 drm/amd/powerplay: fix performance drop on Vega10

  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++++++
  drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h   | 3 ++-
  2 files changed, 8 insertions(+), 1 deletion(-)
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx