Skip to contentSkip to conversation

Patch "xfs: Capture state of the right inode in xfs_iflush_done" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Oct 24, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

xfs: Capture state of the right inode in xfs_iflush_done

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
xfs-capture-state-of-the-right-inode-in-xfs_iflush_done.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 842f6e9f786226c58fcbd5ef80eadca72fdfe652 Mon Sep 17 00:00:00 2001

From: Carlos Maiolino <[email protected]>
Date: Fri, 22 Sep 2017 11:47:46 -0700
Subject: xfs: Capture state of the right inode in xfs_iflush_done

From: Carlos Maiolino <[email protected]>

commit 842f6e9f786226c58fcbd5ef80eadca72fdfe652 upstream.

My previous patch: d3a304b6292168b83b45d624784f973fdc1ca674 check for XFS_LI_FAILED flag xfs_iflush done, so the failed item can be properly resubmitted.

In the loop scanning other inodes being completed, it should check the current item for the XFS_LI_FAILED, and not the initial one.

The state of the initial inode is checked after the loop ends

Kudos to Eric for catching this.

---
 fs/xfs/xfs_inode_item.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_inode_item.c +1 -1
@@ -745,7 +745,7 @@ xfs_iflush_done(
 		 */
 		iip = INODE_ITEM(blip);
 		if ((iip->ili_logged && blip->li_lsn == iip->ili_flush_lsn) ||
-		    lip->li_flags & XFS_LI_FAILED)
+		    (blip->li_flags & XFS_LI_FAILED))
 			need_ail++;
 
 		blip = next;

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/xfs-don-t-unconditionally-clear-the-reflink-flag-on-zero-block-files.patch queue-4.13/xfs-report-zeroed-or-not-correctly-in-xfs_zero_range.patch queue-4.13/xfs-evict-cow-fork-extents-when-performing-finsert-fcollapse.patch queue-4.13/xfs-capture-state-of-the-right-inode-in-xfs_iflush_done.patch