Fix: python bindings when building with PIE hardening
A message that is not in the archive (sent off-list or not yet received): [email protected]
Jérémie Galarneau
AppliedMerged, thanks!
Jérémie
Quoted 29 lines · Michael Jeanson
Work around a bug/limitation in python distutils where object files are built with -fPIC appended after the CFLAGS but the final shared object is linked with -shared before the LDFLAGS which can then be overriden by hardening flags and result in an invalid build.
The work around is to append -shared to the LDFLAGS making sure it's not overriden.
Signed-off-by Michael Jeanson <[email protected]>--- bindings/python/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)bindings/python/Makefile.am +1
-2@@ -25,7 +25,7 @@ BINDINGS_DEPS=setup.py \ BUILD_FLAGS=CC="$(CC)" \ CFLAGS="$(GLIB_CFLAGS) $(AM_CFLAGS) $(CFLAGS)" \ CPPFLAGS="$(DEFS) $(DEFAULT_INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS)" \ - LDFLAGS="$(AM_LDFLAGS) $(LDFLAGS) $(GLIB_LIBS) $(LIBS)" + LDFLAGS="$(AM_LDFLAGS) $(LDFLAGS) $(GLIB_LIBS) -shared $(LIBS)" build-python-bindings.stamp: $(BINDINGS_DEPS) $(BUILD_FLAGS) $(PYTHON) $(builddir)/setup.py build_ext --2.7.4
Signature · 7 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev