drm/stm: checkpatch strict minor updates
Subsystems (4)
PATCH 1/1 drm/stm: checkpatch strict minor updates
Minor fixes detected with "scripts/checkpatch.pl --strict"
--- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- drivers/gpu/drm/stm/ltdc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +2 -2
@@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,int fvco_min, fvco_max, delta, best_delta;/* all in khz */ /* Early checks preventing division by 0 & odd results */ -if ((clkin_khz <=0 ) || (clkout_khz <=0 )) +if (clkin_khz <=0 || clkout_khz <=0 )return -EINVAL ; fvco_min =LANE_MIN_KBPS *2 *ODF_MAX ;
@@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,for (o =ODF_MIN ; o <=ODF_MAX ; o *=2 ) { n =DIV_ROUND_CLOSEST (i * o * clkout_khz, clkin_khz);/* Check ndiv according to vco range */ -if ((n < n_min) || (n > n_max)) +if (n < n_min || n > n_max)continue ;/* Check if new delta is better & saves parameters */ delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) -
drivers/gpu/drm/stm/ltdc.c +1 -1
@@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane, src_h = state->src_h >>16 ;/* Reject scaling */ -if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) { +if (src_w != state->crtc_w || src_h != state->crtc_h) {DRM_ERROR ("Scaling is not supported" );return -EINVAL ; }
Signature · 1 line
1.9.1
2017-10-26 Philippe Cornu <[email protected]>:
Quoted 35 lines
Minor fixes detected with "
scripts/checkpatch.pl--strict"Signed-off-by Philippe Cornu <[email protected]>--- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- drivers/gpu/drm/stm/ltdc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +2
-2@@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,int fvco_min, fvco_max, delta, best_delta;/* all in khz */ /* Early checks preventing division by 0 & odd results */ -if ((clkin_khz <=0 ) || (clkout_khz <=0 )) +if (clkin_khz <=0 || clkout_khz <=0 )return -EINVAL ; fvco_min =LANE_MIN_KBPS *2 *ODF_MAX ;@@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,for (o =ODF_MIN ; o <=ODF_MAX ; o *=2 ) { n =DIV_ROUND_CLOSEST (i * o * clkout_khz, clkin_khz);/* Check ndiv according to vco range */ -if ((n < n_min) || (n > n_max)) +if (n < n_min || n > n_max)continue ;/* Check if new delta is better & saves parameters */ delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) -drivers/gpu/drm/stm/ltdc.c +0
-0
drivers/gpu/drm/stm/ltdc.c static int ltdc_plane_atomic_check(struct drm_plane *plane, · line 561
Quoted 7 lines
drivers/gpu/drm/stm/ltdc.c +1
-1@@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane, src_h = state->src_h >>16 ;/* Reject scaling */ -if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) { +if (src_w != state->crtc_w || src_h != state->crtc_h) {DRM_ERROR ("Scaling is not supported" );return -EINVAL ;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
2017-11-01 12:33 GMT+01:00 Gustavo Padovan <[email protected]>:
Quoted 39 lines
2017-10-26 Philippe Cornu <[email protected]>:
Quoted 37 lines
Minor fixes detected with "
scripts/checkpatch.pl--strict"Signed-off-by Philippe Cornu <[email protected]>--- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- drivers/gpu/drm/stm/ltdc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +2
-2@@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,int fvco_min, fvco_max, delta, best_delta;/* all in khz */ /* Early checks preventing division by 0 & odd results */ -if ((clkin_khz <=0 ) || (clkout_khz <=0 )) +if (clkin_khz <=0 || clkout_khz <=0 )return -EINVAL ; fvco_min =LANE_MIN_KBPS *2 *ODF_MAX ;@@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,for (o =ODF_MIN ; o <=ODF_MAX ; o *=2 ) { n =DIV_ROUND_CLOSEST (i * o * clkout_khz, clkin_khz);/* Check ndiv according to vco range */ -if ((n < n_min) || (n > n_max)) +if (n < n_min || n > n_max)continue ;/* Check if new delta is better & saves parameters */ delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) -drivers/gpu/drm/stm/ltdc.c +0
-0@@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane, src_h = state->src_h >>16 ;
Quoted 8 lines
drivers/gpu/drm/stm/ltdc.c static int ltdc_plane_atomic_check(struct drm_plane *plane, · line 561
Quoted 5 lines
drivers/gpu/drm/stm/ltdc.c +1
-1/* Reject scaling */ -if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) { +if (src_w != state->crtc_w || src_h != state->crtc_h) {DRM_ERROR ("Scaling is not supported" );return -EINVAL ;Reviewed-by Gustavo Padovan <[email protected]>
Applied on drm-misc-next.
Thanks
Benjamin
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel