Skip to contentSkip to conversation

selftests/ftrace: Do not use arch dependent do_IRQ as a target function

PATCH In review Masami Hiramatsu 3 participants 4 messages Oct 27, 2017 – Nov 1, 2017

Subsystems (2)
lore
Share & tools
lore

Masami Hiramatsu

author maintainer
#0 lore raw

PATCH 1/1 selftests/ftrace: Do not use arch dependent do_IRQ as a target function

Instead using arch-dependent do_IRQ, use do_softirq as a target function.

Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any other architectures which don't define do_IRQ. So, instead of using that, use do_softirq which is defined in kernel/softirq.c.

---
 .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +1 -1
index 113b4d9bc733..20f15c858af6 100644
@@ -32,7 +32,7 @@ do_reset
 
 FILTER=set_ftrace_filter
 FUNC1="schedule"
-FUNC2="do_IRQ"
+FUNC2="do_softirq"
 
 ALL_FUNCS="#### all functions enabled ####"
 
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Fri, 27 Oct 2017 15:10:30 +0900 Masami Hiramatsu <[email protected]> wrote:

Instead using arch-dependent do_IRQ, use do_softirq as a target function.

Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any other architectures which don't define do_IRQ. So, instead of using that, use do_softirq which is defined in kernel/softirq.c.

Shuah,

Can you take this in your tree?

Thanks!

-- Steve

Quoted 17 lines
---
 .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +1 -1
index 113b4d9bc733..20f15c858af6 100644
@@ -32,7 +32,7 @@ do_reset
 
 FILTER=set_ftrace_filter
 FUNC1="schedule"
-FUNC2="do_IRQ"
+FUNC2="do_softirq"
 
 ALL_FUNCS="#### all functions enabled ####"
 
maintainer
#2 lore raw
Quoted 14 lines · Steven Rostedt
Quoted 8 lines · On Fri, 27 Oct 2017 15:10:30 +0900 Masami Hiramatsu <[email protected]> wrote:

Instead using arch-dependent do_IRQ, use do_softirq as a target function.

Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any other architectures which don't define do_IRQ. So, instead of using that, use do_softirq which is defined in kernel/softirq.c.

Quoted 7 lines

Shuah,

Can you take this in your tree?

Thanks!

-- Steve

Yes. I will get this in.

thanks,
-- Shuah

maintainer
#3 lore raw
In reply to Masami Hiramatsu
Quoted 20 lines · Masami Hiramatsu

Instead using arch-dependent do_IRQ, use do_softirq as a target function.

Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any other architectures which don't define do_IRQ. So, instead of using that, use do_softirq which is defined in kernel/softirq.c.

---
 .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +0 -0
index 113b4d9bc733..20f15c858af6 100644

tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc do_reset · line 38

Quoted 8 lines
tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +1 -1
@@ -32,7 +32,7 @@ do_reset
 
 FILTER=set_ftrace_filter
 FUNC1="schedule"
-FUNC2="do_IRQ"
+FUNC2="do_softirq"
 
 ALL_FUNCS="#### all functions enabled ####"
 

Looks good to me. I will queue this for 4.15-rc1

thanks,
-- Shuah