gma500: mmu: unmap the correct address
Subsystems (3)
The function kunmap_atomatic() is called on the same variable twice, i.e. pt->v. In the second call, its parameter should be variable v rather than pt->v.
Signed-off-by Pan Bian <[email protected]>
--- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/gma500/mmu.c +1 -1
@@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt)psb_mmu_clflush (pd->driver, (void *)&v[pt->index]);atomic_set (&pd->driver->needs_tlbflush,1 ); } -kunmap_atomic (pt->v); +kunmap_atomic (v);spin_unlock (&pd->driver->lock);psb_mmu_free_pt (pt);return ;
Signature · 1 line
1.9.1
Daniel Vetter
AppliedQuoted 5 lines · Pan Bian
The function
kunmap_atomatic()is called on the same variable twice, i.e.pt->v. In the second call, its parameter should be variable v rather thanpt->v.Signed-off-by Pan Bian <[email protected]>
Makes sense, not sure this ever worked or how it ever worked, but oh well.
Applied to drm-misc-next for 4.16.
-Daniel
Quoted 25 lines
--- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/gma500/mmu.c +1
-1@@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt)psb_mmu_clflush (pd->driver, (void *)&v[pt->index]);atomic_set (&pd->driver->needs_tlbflush,1 ); } -kunmap_atomic (pt->v); +kunmap_atomic (v);spin_unlock (&pd->driver->lock);psb_mmu_free_pt (pt);return ;Signature · 7 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel